[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <168959375926.3515353.7529038208688306372@Monstersaurus>
Date: Mon, 17 Jul 2023 12:35:59 +0100
From: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
To: Abhinav Kumar <quic_abhinavk@...cinc.com>,
Alain Volmat <alain.volmat@...s.st.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Alim Akhtar <alim.akhtar@...sung.com>,
Alyssa Rosenzweig <alyssa.rosenzweig@...labora.com>,
Andrzej Hajda <andrzej.hajda@...el.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>,
Artur Weber <aweber.kernel@...il.com>,
Baolin Wang <baolin.wang@...ux.alibaba.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@...adcom.com>,
Chen-Yu Tsai <wens@...e.org>,
Christian Gmeiner <christian.gmeiner@...il.com>,
Chun-Kuang Hu <chunkuang.hu@...nel.org>,
Chunyan Zhang <zhang.lyra@...il.com>,
Daniel Vetter <daniel@...ll.ch>,
David Airlie <airlied@...il.com>,
Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
Emma Anholt <emma@...olt.net>,
Fabio Estevam <festevam@...il.com>,
Florian Fainelli <florian.fainelli@...adcom.com>,
Guido Günther <agx@...xcpu.org>,
Heiko Stübner <heiko@...ech.de>,
Icenow y Zheng <icenowy@...c.io>,
Inki Dae <inki.dae@...sung.com>,
Jagan Teki <jagan@...rulasolutions.com>,
Javier Martinez Canillas <javierm@...hat.com>,
Jernej Skrabec <jernej.skrabec@...il.com>,
Jerome Brunet <jbrunet@...libre.com>,
Jerry Han <hanxu5@...qin.corp-partner.google.com>,
Jianhua Lu <lujianhua000@...il.com>,
John Stultz <jstultz@...gle.com>,
Jonas Karlman <jonas@...boo.se>,
Jonathan Hunter <jonathanh@...dia.com>,
Jyri Sarha <jyri.sarha@....fi>,
Kevin Hilman <khilman@...libre.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Kyungmin Park <kyungmin.park@...sung.com>,
Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
Laurentiu Palcu <laurentiu.palcu@....nxp.com>,
Linus Walleij <linus.walleij@...aro.org>,
Liu Ying <victor.liu@....com>,
Liviu Dudau <liviu.dudau@....com>,
Lucas Stach <l.stach@...gutronix.de>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Marek Szyprowski <m.szyprowski@...sung.com>,
Marek Vasut <marex@...x.de>,
Marijn Suijten <marijn.suijten@...ainline.org>,
Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
Matthias Brugger <matthias.bgg@...il.com>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Maxime Ripard <mripard@...nel.org>,
Mikko Perttunen <mperttunen@...dia.com>,
NXP Linux Team <linux-imx@....com>,
Neil Armstrong <neil.armstrong@...aro.org>,
Oleksandr Andrushchenko <oleksandr_andrushchenko@...m.com>,
Ondrej Jirman <megi@....cz>, Orson Zhai <orsonzhai@...il.com>,
Paul Cercueil <paul@...pouillou.net>,
Paul Kocialkowski <paul.kocialkowski@...tlin.com>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Philipp Zabel <p.zabel@...gutronix.de>,
Philippe Cornu <philippe.cornu@...s.st.com>,
Purism Kernel Team <kernel@...i.sm>,
Qiang Yu <yuq825@...il.com>,
Raphael Gallais-Pou <raphael.gallais-pou@...s.st.com>,
Rob Clark <robdclark@...il.com>, Rob Herring <robh@...nel.org>,
Robert Foss <rfoss@...nel.org>,
Russell King <linux+etnaviv@...linux.org.uk>,
Sam Ravnborg <sam@...nborg.org>,
Samuel Holland <samuel@...lland.org>,
Sandy Huang <hjc@...k-chips.com>,
Sascha Hauer <s.hauer@...gutronix.de>,
Sean Paul <sean@...rly.run>,
Seung-Woo Kim <sw0312.kim@...sung.com>,
Shawn Guo <shawnguo@...nel.org>,
Stefan Agner <stefan@...er.ch>,
Steven Price <steven.price@....com>,
Sumit Semwal <sumit.semwal@...aro.org>,
Thierry Reding <thierry.reding@...il.com>,
Thomas Zimmermann <tzimmermann@...e.de>,
Tian Tao <tiantao6@...ilicon.com>,
Tomeu Vizoso <tomeu.vizoso@...labora.com>,
Tomi Valkeinen <tomba@...nel.org>,
Xinliang Liu <xinliang.liu@...aro.org>,
Xinwei Kong <kong.kongxinwei@...ilicon.com>,
Yannick Fertre <yannick.fertre@...s.st.com>,
Yongqin Liu <yongqin.liu@...aro.org>
Cc: devicetree@...r.kernel.org, Ondrej Jirman <megous@...ous.com>,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
etnaviv@...ts.freedesktop.org, linux-samsung-soc@...r.kernel.org,
linux-mips@...r.kernel.org, lima@...ts.freedesktop.org,
linux-mediatek@...ts.infradead.org,
linux-amlogic@...ts.infradead.org, linux-arm-msm@...r.kernel.org,
freedreno@...ts.freedesktop.org,
linux-rpi-kernel@...ts.infradead.org,
linux-renesas-soc@...r.kernel.org,
linux-rockchip@...ts.infradead.org,
linux-stm32@...md-mailman.stormreply.com,
linux-sunxi@...ts.linux.dev, linux-tegra@...r.kernel.org,
xen-devel@...ts.xenproject.org
Subject: Re: [PATCH] drm: Explicitly include correct DT includes
Quoting Rob Herring (2023-07-14 18:45:34)
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
>
> Signed-off-by: Rob Herring <robh@...nel.org>
> drivers/gpu/drm/renesas/rcar-du/rcar_du_drv.c | 2 +-
> drivers/gpu/drm/renesas/rcar-du/rcar_du_kms.c | 2 ++
> drivers/gpu/drm/renesas/rcar-du/rcar_du_vsp.c | 1 +
> drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi.c | 1 -
> drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c | 1 -
For drivers/gpu/drm/renesas/rcar-du/
> diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/renesas/rcar-du/rcar_du_drv.c
> index 1ffde19cb87f..3904b0cca814 100644
> --- a/drivers/gpu/drm/renesas/rcar-du/rcar_du_drv.c
> +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_du_drv.c
> @@ -12,7 +12,7 @@
> #include <linux/io.h>
> #include <linux/mm.h>
> #include <linux/module.h>
> -#include <linux/of_device.h>
> +#include <linux/of.h>
> #include <linux/platform_device.h>
> #include <linux/pm.h>
> #include <linux/slab.h>
> diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/renesas/rcar-du/rcar_du_kms.c
> index adfb36b0e815..9ff4537c26c8 100644
> --- a/drivers/gpu/drm/renesas/rcar-du/rcar_du_kms.c
> +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_du_kms.c
> @@ -20,8 +20,10 @@
>
> #include <linux/device.h>
> #include <linux/dma-buf.h>
> +#include <linux/of.h>
> #include <linux/of_graph.h>
> #include <linux/of_platform.h>
> +#include <linux/platform_device.h>
> #include <linux/wait.h>
>
> #include "rcar_du_crtc.h"
> diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_du_vsp.c b/drivers/gpu/drm/renesas/rcar-du/rcar_du_vsp.c
> index 45c05d0ffc70..9cbb5e6e2cba 100644
> --- a/drivers/gpu/drm/renesas/rcar-du/rcar_du_vsp.c
> +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_du_vsp.c
> @@ -22,6 +22,7 @@
> #include <linux/bitops.h>
> #include <linux/dma-mapping.h>
> #include <linux/of_platform.h>
> +#include <linux/platform_device.h>
> #include <linux/scatterlist.h>
> #include <linux/slab.h>
> #include <linux/videodev2.h>
> diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi.c b/drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi.c
> index e10e4d4b89a2..db2e6f16f954 100644
> --- a/drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi.c
> +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi.c
> @@ -12,7 +12,6 @@
> #include <linux/math64.h>
> #include <linux/module.h>
> #include <linux/of.h>
> -#include <linux/of_device.h>
> #include <linux/of_graph.h>
> #include <linux/platform_device.h>
> #include <linux/reset.h>
> diff --git a/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c b/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c
> index aa95b85a2964..8048bdca2d6c 100644
> --- a/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c
> +++ b/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c
> @@ -10,7 +10,6 @@
> #include <linux/iopoll.h>
> #include <linux/module.h>
> #include <linux/of.h>
> -#include <linux/of_device.h>
> #include <linux/of_graph.h>
> #include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
Powered by blists - more mailing lists