[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230717114133.GE1901145@kernel.org>
Date: Mon, 17 Jul 2023 14:41:33 +0300
From: Mike Rapoport <rppt@...nel.org>
To: Haifeng Xu <haifeng.xu@...pee.com>
Cc: akpm@...ux-foundation.org, linux-mm@...ck.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/mm_init.c: drop node_start_pfn from
adjust_zone_range_for_zone_movable()
On Mon, Jul 17, 2023 at 06:58:11AM +0000, Haifeng Xu wrote:
> node_start_pfn is not used in adjust_zone_range_for_zone_movable(), so
> it is pointless to waste a function argument. Drop the parameter.
>
> Signed-off-by: Haifeng Xu <haifeng.xu@...pee.com>
Reviewed-by: Mike Rapoport (IBM) <rppt@...nel.org>
> ---
> mm/mm_init.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/mm/mm_init.c b/mm/mm_init.c
> index a313d1828a6c..23d50541e1f7 100644
> --- a/mm/mm_init.c
> +++ b/mm/mm_init.c
> @@ -1105,7 +1105,6 @@ void __ref memmap_init_zone_device(struct zone *zone,
> */
> static void __init adjust_zone_range_for_zone_movable(int nid,
> unsigned long zone_type,
> - unsigned long node_start_pfn,
> unsigned long node_end_pfn,
> unsigned long *zone_start_pfn,
> unsigned long *zone_end_pfn)
> @@ -1222,9 +1221,8 @@ static unsigned long __init zone_spanned_pages_in_node(int nid,
> /* Get the start and end of the zone */
> *zone_start_pfn = clamp(node_start_pfn, zone_low, zone_high);
> *zone_end_pfn = clamp(node_end_pfn, zone_low, zone_high);
> - adjust_zone_range_for_zone_movable(nid, zone_type,
> - node_start_pfn, node_end_pfn,
> - zone_start_pfn, zone_end_pfn);
> + adjust_zone_range_for_zone_movable(nid, zone_type, node_end_pfn,
> + zone_start_pfn, zone_end_pfn);
>
> /* Check that this node has pages within the zone's required range */
> if (*zone_end_pfn < node_start_pfn || *zone_start_pfn > node_end_pfn)
> --
> 2.25.1
>
--
Sincerely yours,
Mike.
Powered by blists - more mailing lists