linux-kernel - Re: [PATCH] arm64: dts: qcom: msm8916-samsung-e2015: Add accelerometer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f7fa82e3-ee2e-da05-f635-ba93819790ce@linaro.org>
Date:   Mon, 17 Jul 2023 14:30:36 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     "Lin, Meng-Bo" <linmengbo0689@...tonmail.com>,
        linux-kernel@...r.kernel.org
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Stephan Gerhold <stephan@...hold.net>,
        Nikita Travkin <nikita@...n.ru>, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH] arm64: dts: qcom: msm8916-samsung-e2015: Add
 accelerometer

On 15.07.2023 22:41, Lin, Meng-Bo wrote:
> E5, E7 and Grand Max have ST LIS2HH12 accelerometer.
> Add support for it.
> 
> Signed-off-by: Stephan Gerhold <stephan@...hold.net>
> Signed-off-by: Lin, Meng-Bo <linmengbo0689@...tonmail.com>
> ---
Potentially missing Co-Developed-by?

>  .../qcom/msm8916-samsung-e2015-common.dtsi    | 21 +++++++++++++++++--
>  1 file changed, 19 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-e2015-common.dtsi b/arch/arm64/boot/dts/qcom/msm8916-samsung-e2015-common.dtsi
> index 0cdd6af7817f..ef7c7ac40e05 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916-samsung-e2015-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-e2015-common.dtsi
> @@ -42,10 +42,27 @@ reg_touch_key: regulator-touch-key {
>  
>  &blsp_i2c2 {
>  	/* lis2hh12 accelerometer instead of BMC150 */
> -	status = "disabled";
> -
>  	/delete-node/ accelerometer@10;
>  	/delete-node/ magnetometer@12;
> +
> +	accelerometer@1d {
> +		compatible = "st,lis2hh12";
> +		reg = <0x1d>;
> +
> +		interrupt-parent = <&msmgpio>;
> +		interrupts = <115 IRQ_TYPE_LEVEL_HIGH>;
interrupts-extended = <&msmgpio 115 IRQ_TYPE_LEVEL_HIGH>;

Konrad
> +
> +		vdd-supply = <&pm8916_l5>;
> +		vddio-supply = <&pm8916_l5>;
> +
> +		st,drdy-int-pin = <1>;
> +		mount-matrix = "1", "0", "0",
> +			       "0", "-1", "0",
> +			       "0", "0", "1";
> +
> +		pinctrl-0 = <&accel_int_default>;
> +		pinctrl-names = "default";
> +	};
>  };
>  
>  &reg_motor_vdd {