[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2023071726-zap-sesame-c8ff@gregkh>
Date: Mon, 17 Jul 2023 15:42:00 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Joaquín Ignacio Aramendía <samsagax@...il.com>
Cc: linux@...ck-us.net, linux-hwmon@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] hwmon: (oxp-sensors) Move tt_toggle attribute to
dev_groups
On Mon, Jul 17, 2023 at 09:40:04AM -0300, Joaquín Ignacio Aramendía wrote:
> A driver should not be manually adding groups in its probe function (it will
> race with userspace), so replace the call to devm_device_add_groups() to use
> the platform dev_groups callback instead.
>
> This will allow for removal of the devm_device_add_groups() function.
> ---
> drivers/hwmon/oxp-sensors.c | 38 +++++++++++++++++++++++--------------
> 1 file changed, 24 insertions(+), 14 deletions(-)
Nice, but you forgot a signed-off-by: line :(
Powered by blists - more mailing lists