linux-kernel - Re: [External] [PATCH v1] platform: x86: Use kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9f0dae3b-c964-b100-c2cf-25eced14e207@lenovo.com>
Date:   Mon, 17 Jul 2023 09:42:36 -0400
From:   Mark Pearson <markpearson@...ovo.com>
To:     Wang Ming <machel@...o.com>, Hans de Goede <hdegoede@...hat.com>,
        "Mark Gross" <markgross@...nel.org>,
        <platform-driver-x86@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
CC:     <opensource.kernel@...o.com>
Subject: Re: [External] [PATCH v1] platform: x86: Use kfree_sensitive instead
 of kfree

On 7/17/23 06:11, Wang Ming wrote:
> key might contain private part of the key, so better use
> kfree_sensitive to free it.
>
> Signed-off-by: Wang Ming <machel@...o.com>
> ---
>   drivers/platform/x86/think-lmi.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/think-lmi.c b/drivers/platform/x86/think-lmi.c
> index 52d1ce8dfe44..79346881cadb 100644
> --- a/drivers/platform/x86/think-lmi.c
> +++ b/drivers/platform/x86/think-lmi.c
> @@ -719,12 +719,12 @@ static ssize_t cert_to_password_store(struct kobject *kobj,
>   	/* Format: 'Password,Signature' */
>   	auth_str = kasprintf(GFP_KERNEL, "%s,%s", passwd, setting->signature);
>   	if (!auth_str) {
> -		kfree(passwd);
> +		kfree_sensitive(passwd);
>   		return -ENOMEM;
>   	}
>   	ret = tlmi_simple_call(LENOVO_CERT_TO_PASSWORD_GUID, auth_str);
>   	kfree(auth_str);
> -	kfree(passwd);
> +	kfree_sensitive(passwd);
>   
>   	return ret ?: count;
>   }

I wasn't aware of kfree_sensitive - looks good to me!

Thank you

Mark