linux-kernel - Re: [PATCH] platforms: 52xx: Remove space after '(' and before ')'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZLacxHz/IGgketWx@smile.fi.intel.com>
Date:   Tue, 18 Jul 2023 17:08:04 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     hanyu001@...suo.com
Cc:     agust@...x.de, mpe@...erman.id.au, npiggin@...il.com,
        christophe.leroy@...roup.eu, bhelgaas@...gle.com, kw@...ux.com,
        mika.westerberg@...ux.intel.com, linuxppc-dev@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platforms: 52xx: Remove space after '(' and before ')'

On Tue, Jul 18, 2023 at 05:02:39PM +0800, hanyu001@...suo.com wrote:
> The patch fixes the following errors detected by checkpatch:
> 
> platforms/52xx/mpc52xx_pci.c:346:ERROR: space prohibited after that open
> parenthesis '('
> platforms/52xx/mpc52xx_pci.c:347:ERROR: space prohibited after that open
> parenthesis '('
> platforms/52xx/mpc52xx_pci.c:348:ERROR: space prohibited before that close
> parenthesis ')'

First of all, your patch is mangled and may not be applied.
Second, we usually don't do this kind of patches at all.
Besides the fact that we don't run checkpatch on the files
which are already in upstream (esp. so-o-o old as this one).

NAK.

...

> +    if ((dev->vendor == PCI_VENDOR_ID_MOTOROLA) &&
> +         (dev->device == PCI_DEVICE_ID_MOTOROLA_MPC5200
> +          || dev->device == PCI_DEVICE_ID_MOTOROLA_MPC5200B)) {

Also note, you can move this to use pci_match_id().
That kind of patch might be approved.

-- 
With Best Regards,
Andy Shevchenko