[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230718164251.13855c47@md1za8fc.ad001.siemens.net>
Date: Tue, 18 Jul 2023 16:42:51 +0200
From: Henning Schild <henning.schild@...mens.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Lee Jones <lee@...nel.org>, Hans de Goede <hdegoede@...hat.com>,
Wim Van Sebroeck <wim@...ux-watchdog.org>,
Guenter Roeck <linux@...ck-us.net>,
linux-kernel@...r.kernel.org, linux-leds@...r.kernel.org,
platform-driver-x86@...r.kernel.org,
linux-watchdog@...r.kernel.org, Pavel Machek <pavel@....cz>,
Mark Gross <markgross@...nel.org>,
Tobias Schaffner <tobias.schaffner@...mens.com>
Subject: Re: [PATCH 1/3] watchdog: make Siemens Simatic watchdog driver
default on platform
Am Tue, 18 Jul 2023 17:20:48 +0300
schrieb Andy Shevchenko <andriy.shevchenko@...ux.intel.com>:
> On Tue, Jul 18, 2023 at 12:52:11PM +0200, Henning Schild wrote:
> > If a user did choose to enable Siemens Simatic platform support they
> > likely want that driver to be enabled without having to flip more
> > config switches. So we make the watchdog driver config switch
> > default to the platform driver switches value.
>
> A nit-pick below.
>
> ...
>
> > config SIEMENS_SIMATIC_IPC_WDT
> > tristate "Siemens Simatic IPC Watchdog"
> > depends on SIEMENS_SIMATIC_IPC
>
> > + default SIEMENS_SIMATIC_IPC
>
> It's more natural to group tristate and default, vs. depends and
> select.
Will be ignored unless maintainer insists.
Henning
>
> > select WATCHDOG_CORE
> > select P2SB
>
Powered by blists - more mailing lists