linux-kernel - Re: [PATCH v7 1/2] docs: Move rustdoc output, cross-reference it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72nmeXwS06w2AwJ5OdC14x_5Gp-GmksrBJXiUiZuy7y7hg@mail.gmail.com>
Date:   Tue, 18 Jul 2023 17:24:36 +0200
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Carlos Bilbao <carlos.bilbao@....com>
Cc:     corbet@....net, ojeda@...nel.org, jani.nikula@...ux.intel.com,
        rdunlap@...radead.org, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, konstantin@...uxfoundation.org,
        Akira Yokosawa <akiyks@...il.com>,
        rust-for-linux <rust-for-linux@...r.kernel.org>
Subject: Re: [PATCH v7 1/2] docs: Move rustdoc output, cross-reference it

On Tue, Jul 18, 2023 at 3:50 PM Carlos Bilbao <carlos.bilbao@....com> wrote:
>
> On 7/17/23 11:37, Miguel Ojeda wrote:
> >
> > Also, I assume this is intended to be overridable by the user, right?
> > i.e. that is why you wrote the identifier as uppercase.
>
> That's true, I don't see any reason to make this uppercase.

I don't know -- perhaps users may want to override the output
location. `BUILDDIR` is intended to be overridable, so we should
consider what should be the behavior when one overrides one but not
the other. Or perhaps this one shouldn't be overridable, like you did
in v8, in which case we should still make sure things work if that one
(`BUILDDIR`) is overridden.

Cheers,
Miguel