linux-kernel - Re: [PATCH 1/2] nvmem: core: clear sysfs attributes for each NVMEM device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZLavw9ZyXMWMqTu_@makrotopia.org>
Date:   Tue, 18 Jul 2023 16:29:07 +0100
From:   Daniel Golle <daniel@...rotopia.org>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:     Miquel Raynal <miquel.raynal@...tlin.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] nvmem: core: clear sysfs attributes for each NVMEM
 device

On Tue, Jul 18, 2023 at 03:55:56PM +0100, Srinivas Kandagatla wrote:
> HI Daniel,
> 
> On 18/07/2023 14:55, Daniel Golle wrote:
> > Set nvmem_cells_group.bin_attrs to NULL in case of an NVMEM device not
> > having any cells in order to make sure sysfs attributes of a previously
> > registered NVMEM device are not accidentally reused for a follow-up
> > device which doesn't have any cells.
> > 
> > Fixes: 757f8b3835c9 ("nvmem: core: Expose cells through sysfs")
> 
> These patches are dropped out of nvmem next branch as it was breaking some
> existing users.

Ok. I've encountered those commits in linux-next and can confirm that
they were definitely also breaking things here, hence my patches at
least partially fixing that.

I agree that reverting them for now and reworking them seems to be the
better option in this case, hence my patches won't be needed as such.

> 
> 
> --srini
> > Signed-off-by: Daniel Golle <daniel@...rotopia.org>
> > ---
> >   drivers/nvmem/core.c | 5 +++--
> >   1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
> > index 6c04a9cf6919f..70e951088826d 100644
> > --- a/drivers/nvmem/core.c
> > +++ b/drivers/nvmem/core.c
> > @@ -458,9 +458,10 @@ static int nvmem_populate_sysfs_cells(struct nvmem_device *nvmem)
> >   	mutex_lock(&nvmem_mutex);
> > -	if (list_empty(&nvmem->cells))
> > +	if (list_empty(&nvmem->cells)) {
> > +		nvmem_cells_group.bin_attrs = NULL;
> >   		goto unlock_mutex;
> > -
> > +	}
> >   	/* Allocate an array of attributes with a sentinel */
> >   	ncells = list_count_nodes(&nvmem->cells);
> >   	cells_attrs = devm_kcalloc(&nvmem->dev, ncells + 1,