[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a89d5dab-4c52-0bff-ad35-080e62a57447@suse.com>
Date: Tue, 18 Jul 2023 17:31:59 +0200
From: Juergen Gross <jgross@...e.com>
To: Thomas Gleixner <tglx@...utronix.de>,
LKML <linux-kernel@...r.kernel.org>
Cc: x86@...nel.org, Linus Torvalds <torvalds@...ux-foundation.org>,
Andrew Cooper <andrew.cooper3@...rix.com>,
Tom Lendacky <thomas.lendacky@....com>,
Paolo Bonzini <pbonzini@...hat.com>,
Wei Liu <wei.liu@...nel.org>,
Arjan van de Ven <arjan@...ux.intel.com>
Subject: Re: [patch 54/58] x86/xen/apic: Mark apic __ro_after_init
On 18.07.23 01:15, Thomas Gleixner wrote:
> Nothing can change it post init.
>
> While at it mop up the whitespace damage which causes eyebleed due to an
> editor which is highlighting it.
>
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Cc: Juergen Gross <jgross@...e.com>
> ---
> arch/x86/xen/apic.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> --- a/arch/x86/xen/apic.c
> +++ b/arch/x86/xen/apic.c
> @@ -123,9 +123,9 @@ static int xen_cpu_present_to_apicid(int
> return BAD_APICID;
> }
>
> -static struct apic xen_pv_apic = {
> - .name = "Xen PV",
> - .probe = xen_apic_probe_pv,
> +static struct apic xen_pv_apic __ro_after_init = {
> + .name = "Xen PV",
> + .probe = xen_apic_probe_pv,
> .acpi_madt_oem_check = xen_madt_oem_check,
>
> /* .delivery_mode and .dest_mode_logical not used by XENPV */
> @@ -138,24 +138,24 @@ static struct apic xen_pv_apic = {
> .phys_pkg_id = xen_phys_pkg_id, /* detect_ht */
>
> .max_apic_id = UINT_MAX,
> - .get_apic_id = xen_get_apic_id,
> - .set_apic_id = xen_set_apic_id, /* Can be NULL on 32-bit. */
> + .get_apic_id = xen_get_apic_id,
> + .set_apic_id = xen_set_apic_id, /* Can be NULL on 32-bit. */
While changing this line, could you please drop the comment here?
32-bit is irrelevant, as Xen PV is 64-bit only these days.
Juergen
Download attachment "OpenPGP_0xB0DE9DD628BF132F.asc" of type "application/pgp-keys" (3099 bytes)
Download attachment "OpenPGP_signature" of type "application/pgp-signature" (496 bytes)
Powered by blists - more mailing lists