linux-kernel - Re: [GIT PULL] objtool/urgent for v6.5-rc2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHk-=wg4Ajeu-Ju4TsZ+Y83ksb+Z=VMyy--gf1uZzj7Vc5D1ag@mail.gmail.com>
Date:   Tue, 18 Jul 2023 08:41:29 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Vegard Nossum <vegard.nossum@...cle.com>
Cc:     Borislav Petkov <bp@...en8.de>, x86-ml <x86@...nel.org>,
        lkml <linux-kernel@...r.kernel.org>,
        Josh Poimboeuf <jpoimboe@...nel.org>,
        Jens Axboe <axboe@...nel.dk>,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [GIT PULL] objtool/urgent for v6.5-rc2

On Tue, 18 Jul 2023 at 04:02, Vegard Nossum <vegard.nossum@...cle.com> wrote:
>
> If you are willing to add another helper function that also takes the
> label argument, you could do something like this:

Ugh. That's a bit uglier than I was hoping for.

I was hoping more like "use this special attribute to mark this asm as
being something that cannot be moved across function boundaries".

Now a "we have to make up horrible games and pass in labels that are
not used and use a completely different API".

Oh well.

I guess in the end we can just continue to work around this.

After all, in many ways this isn't about the code - the AC setting and
clearing is fine - it's about objtool not doing the analysis across
function boundaries.

I guess we could have just marked these iovec copy functions
"always_inline" too, and avoided it that way.

              Linus