linux-kernel - Re: [patch 54/58] x86/xen/apic: Mark apic __ro_after

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <875y6hxlfu.ffs@tglx>
Date:   Tue, 18 Jul 2023 17:56:37 +0200
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Juergen Gross <jgross@...e.com>,
        LKML <linux-kernel@...r.kernel.org>
Cc:     x86@...nel.org, Linus Torvalds <torvalds@...ux-foundation.org>,
        Andrew Cooper <andrew.cooper3@...rix.com>,
        Tom Lendacky <thomas.lendacky@....com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Wei Liu <wei.liu@...nel.org>,
        Arjan van de Ven <arjan@...ux.intel.com>
Subject: Re: [patch 54/58] x86/xen/apic: Mark apic __ro_after_init

On Tue, Jul 18 2023 at 17:31, Juergen Gross wrote:
> On 18.07.23 01:15, Thomas Gleixner wrote:
>> +	.get_apic_id			= xen_get_apic_id,
>> +	.set_apic_id			= xen_set_apic_id, /* Can be NULL on 32-bit. */
>
> While changing this line, could you please drop the comment here?
>
> 32-bit is irrelevant, as Xen PV is 64-bit only these days.

Sure.