linux-kernel - Re: [PATCH v4 6/6] mmc: sdhci-cadence: Add debug option for SD6 controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202307182343.ZsoiCcbg-lkp@intel.com>
Date:   Wed, 19 Jul 2023 00:10:56 +0800
From:   kernel test robot <lkp@...el.com>
To:     Piyush Malgujar <pmalgujar@...vell.com>, linux-mmc@...r.kernel.org,
        linux-kernel@...r.kernel.org, adrian.hunter@...el.com,
        ulf.hansson@...aro.org, p.zabel@...gutronix.de, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        yamada.masahiro@...ionext.com, devicetree@...r.kernel.org
Cc:     oe-kbuild-all@...ts.linux.dev, jannadurai@...vell.com,
        cchavva@...vell.com, Piyush Malgujar <pmalgujar@...vell.com>
Subject: Re: [PATCH v4 6/6] mmc: sdhci-cadence: Add debug option for SD6
 controller

Hi Piyush,

kernel test robot noticed the following build errors:

[auto build test ERROR on ulf-hansson-mmc-mirror/next]
[also build test ERROR on robh/for-next linus/master v6.5-rc2 next-20230718]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Piyush-Malgujar/mmc-sdhci-cadence-Rename-functions-structures-to-SD4-specific/20230718-175102
base:   https://git.linaro.org/people/ulf.hansson/mmc-mirror.git next
patch link:    https://lore.kernel.org/r/20230717125146.16791-7-pmalgujar%40marvell.com
patch subject: [PATCH v4 6/6] mmc: sdhci-cadence: Add debug option for SD6 controller
config: csky-randconfig-r023-20230718 (https://download.01.org/0day-ci/archive/20230718/202307182343.ZsoiCcbg-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230718/202307182343.ZsoiCcbg-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307182343.ZsoiCcbg-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/mmc/host/sdhci-cadence.c: In function 'sdhci_cdns_sd6_dump':
>> drivers/mmc/host/sdhci-cadence.c:1066:9: error: too few arguments to function 'sdhci_cdns_sd6_phy_dump'
    1066 |         sdhci_cdns_sd6_phy_dump(phy);
         |         ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/mmc/host/sdhci-cadence.c:981:6: note: declared here
     981 | void sdhci_cdns_sd6_phy_dump(struct sdhci_cdns_sd6_phy *phy,
         |      ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/mmc/host/sdhci-cadence.c: In function 'sdhci_cdns_probe':
   drivers/mmc/host/sdhci-cadence.c:1973:9: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
    1973 |         static const u16 version = SDHCI_SPEC_400 << SDHCI_SPEC_VER_SHIFT;
         |         ^~~~~~


vim +/sdhci_cdns_sd6_phy_dump +1066 drivers/mmc/host/sdhci-cadence.c

  1059	
  1060	static
  1061	void sdhci_cdns_sd6_dump(struct sdhci_cdns_priv *priv, struct sdhci_host *host)
  1062	{
  1063		struct sdhci_cdns_sd6_phy *phy = priv->phy;
  1064		int id;
  1065	
> 1066		sdhci_cdns_sd6_phy_dump(phy);
  1067	
  1068		dev_dbg(mmc_dev(host->mmc), "Host controller Register Dump\n");
  1069		for (id = 0; id < 14; id++) {
  1070			dev_dbg(mmc_dev(host->mmc), "HRS%d 0x%x\n", id,
  1071				readl(priv->hrs_addr + (id * 4)));
  1072		}
  1073	
  1074		id = 29;
  1075		dev_dbg(mmc_dev(host->mmc), "HRS%d 0x%x\n", id,
  1076			readl(priv->hrs_addr + (id * 4)));
  1077		id = 30;
  1078		dev_dbg(mmc_dev(host->mmc), "HRS%d 0x%x\n", id,
  1079			readl(priv->hrs_addr + (id * 4)));
  1080	
  1081		for (id = 0; id < 27; id++) {
  1082			dev_dbg(mmc_dev(host->mmc), "SRS%d 0x%x\n", id,
  1083				readl(priv->hrs_addr + 0x200 + (id * 4)));
  1084		}
  1085	
  1086		dev_dbg(mmc_dev(host->mmc), "SDHCI_CDNS_SD6_PHY_DQS_TIMING 0x%x\n",
  1087			sdhci_cdns_sd6_read_phy_reg(priv,
  1088						    SDHCI_CDNS_SD6_PHY_DQS_TIMING));
  1089		dev_dbg(mmc_dev(host->mmc), "SDHCI_CDNS_SD6_PHY_GATE_LPBK 0x%x\n",
  1090			sdhci_cdns_sd6_read_phy_reg(priv,
  1091						    SDHCI_CDNS_SD6_PHY_GATE_LPBK));
  1092		dev_dbg(mmc_dev(host->mmc), "SDHCI_CDNS_SD6_PHY_DLL_MASTER 0x%x\n",
  1093			sdhci_cdns_sd6_read_phy_reg(priv,
  1094						    SDHCI_CDNS_SD6_PHY_DLL_MASTER));
  1095		dev_dbg(mmc_dev(host->mmc), "SDHCI_CDNS_SD6_PHY_DLL_SLAVE 0x%x\n",
  1096			sdhci_cdns_sd6_read_phy_reg(priv,
  1097						    SDHCI_CDNS_SD6_PHY_DLL_SLAVE));
  1098		dev_dbg(mmc_dev(host->mmc), "SDHCI_CDNS_SD6_PHY_CTRL 0x%x\n",
  1099			sdhci_cdns_sd6_read_phy_reg(priv, SDHCI_CDNS_SD6_PHY_CTRL));
  1100		dev_dbg(mmc_dev(host->mmc), "SDHCI_CDNS_SD6_PHY_GPIO_CTRL0 0x%x\n",
  1101			sdhci_cdns_sd6_read_phy_reg(priv,
  1102						    SDHCI_CDNS_SD6_PHY_GPIO_CTRL0));
  1103		dev_dbg(mmc_dev(host->mmc), "SDHCI_CDNS_SD6_PHY_DQ_TIMING 0x%x\n",
  1104			sdhci_cdns_sd6_read_phy_reg(priv,
  1105						    SDHCI_CDNS_SD6_PHY_DQ_TIMING));
  1106		dev_dbg(mmc_dev(host->mmc), "SDHCI_CDNS_SD6_PHY_DLL_OBS_REG0 0x%x\n",
  1107			sdhci_cdns_sd6_read_phy_reg(priv,
  1108						    SDHCI_CDNS_SD6_PHY_DLL_OBS_REG0));
  1109		dev_dbg(mmc_dev(host->mmc), "SDHCI_CDNS_SD6_PHY_DLL_OBS_REG1 0x%x\n",
  1110			sdhci_cdns_sd6_read_phy_reg(priv,
  1111						    SDHCI_CDNS_SD6_PHY_DLL_OBS_REG1));
  1112		dev_dbg(mmc_dev(host->mmc), "SDHCI_CDNS_SD6_PHY_DLL_OBS_REG2 0x%x\n",
  1113			sdhci_cdns_sd6_read_phy_reg(priv,
  1114						    SDHCI_CDNS_SD6_PHY_DLL_OBS_REG2));
  1115	}
  1116	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki