linux-kernel - Re: [PATCH] drivers/tty: Fix typos in comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 18 Jul 2023 18:40:03 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     pangzizhen001@...suo.com
Cc:     jirislaby@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/tty: Fix typos in comments

On Wed, Jul 19, 2023 at 12:22:25AM +0800, pangzizhen001@...suo.com wrote:
> Delete duplicate word "the"
> 
> Signed-off-by: wangjianli <wangjianli@...rlc.com>
> ---
>  drivers/tty/n_gsm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
> index b411a26cc092..e8cd1e07eafe 100644
> --- a/drivers/tty/n_gsm.c
> +++ b/drivers/tty/n_gsm.c
> @@ -1148,7 +1148,7 @@ static void __gsm_data_queue(struct gsm_dlci *dlci,
> struct gsm_msg *msg)
>   *
>   *    Add data to the transmit queue and try and get stuff moving
>   *    out of the mux tty if not already doing so. Take the
> - *    the gsm tx lock and dlci lock.
> + *    gsm tx lock and dlci lock.
>   */
> 
>  static void gsm_data_queue(struct gsm_dlci *dlci, struct gsm_msg *msg)

Please learn how to get involved in kernel development by working in
drivers/staging/* first, as the developers there are used to simple
errors like what you did here, and will work to help you out.

Otherwise, patches like this are just going to cause developers to get
grumpy when you have obvious errors.

good luck!

greg k-h