linux-kernel - RE: [PATCH] taging: fbtft: Add space around '='

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ca3fb1d8442c4de4949ecfd71c23b058@realtek.com>
Date:   Tue, 18 Jul 2023 00:29:58 +0000
From:   Ping-Ke Shih <pkshih@...ltek.com>
To:     "hanyu001@...suo.com" <hanyu001@...suo.com>,
        "toke@...e.dk" <toke@...e.dk>,
        "kvalo@...nel.org" <kvalo@...nel.org>
CC:     "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] taging: fbtft: Add space around '='



> -----Original Message-----
> From: hanyu001@...suo.com <hanyu001@...suo.com>
> Sent: Monday, July 17, 2023 4:16 PM
> To: toke@...e.dk; kvalo@...nel.org
> Cc: linux-wireless@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH] taging: fbtft: Add space around '='
> 
> Fix checkpatch warnings:
> 
> ./drivers/staging/media/av7110/dvb_filter.c:105: ERROR: spaces required
> around that '=' (ctx:VxV)
> ./drivers/staging/media/av7110/dvb_filter.c:106: ERROR: spaces required
> around that '=' (ctx:VxV)
> ./drivers/staging/media/av7110/dvb_filter.c:108: ERROR: spaces required
> around that '=' (ctx:VxV)
> ./drivers/staging/media/av7110/dvb_filter.c:112: ERROR: spaces required
> around that '=' (ctx:VxV)
> 
> Signed-off-by: maqimei <2433033762@...com>
> ---
>   drivers/staging/media/av7110/dvb_filter.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/media/av7110/dvb_filter.c
> b/drivers/staging/media/av7110/dvb_filter.c
> index 8c2eca5..014fa1f 100644
> --- a/drivers/staging/media/av7110/dvb_filter.c
> +++ b/drivers/staging/media/av7110/dvb_filter.c
> @@ -102,14 +102,14 @@ int dvb_filter_pes2ts(struct dvb_filter_pes2ts
> *p2ts, unsigned char *pes,
>       }
>       if (!len)
>           return 0;
> -    buf[3]=0x30|((p2ts->cc++)&0x0f);
> -    rest=183-len;
> +    buf[3] = 0x30|((p2ts->cc++)&0x0f);
> +    rest = 183-len;

Adding spaces around operators | and & would look better:
  buf[3] = 0x30 | ((p2ts->cc++) & 0x0f);
  rest = 183 - len;