linux-kernel - Re: ANNOUNCE: thunderbolt-utils-v0.1-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2023071834-audibly-proton-6a3a@gregkh>
Date:   Tue, 18 Jul 2023 19:54:49 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Rajat Khandelwal <rajat.khandelwal@...ux.intel.com>
Cc:     Mika Westerberg <mika.westerberg@...ux.intel.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-usb@...r.kernel.org,
        "Khandelwal, Rajat" <rajat.khandelwal@...el.com>
Subject: Re: ANNOUNCE: thunderbolt-utils-v0.1-rc1

On Tue, Jul 18, 2023 at 10:02:57PM +0530, Rajat Khandelwal wrote:
> Hi,
> 
> This is an official announcement that 'thunderbolt-utils', a collection of
> user-space utilities for the TBT/USB4 subsystem is now made public for its first
> release candidate.
> 
> # What is it?
> 
> The utilities comprise 'lstbt', similar in lines with 'lspci' and 'lsusb',
> which polls the TBT/USB4 subsystem's information including enumerated
> retimers.
> 
> The secondary component of the utilities is the goal towards providing
> a collection of available wrappers to provide the abstraction of configuring
> the subsystem in user-space. This is made possible via porting the DMA layer
> from kernel-space to user-space for the subsystem in an IOMMU-protected
> environment.

Cool, but it doesn't build as a normal user:

/usr/bin/ld: cannot open output file /usr/bin/lstbt: Permission denied

Why aren't you using autotools to properly be able to integrate into
everyone's build systems?

Also, you are shelling out to bash a lot, and as root, in this program,
are you sure that's ok?

And finally, why not add some of the USB4 stuff to usbutils?  Wouldn't
that be a bit more relevant for people who use those tools already?

thanks,

greg k-h