[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMRc=McCwXeJpKuvHY4aheURimqh3ZznvVXKxsV2HzeT0=QYGQ@mail.gmail.com>
Date: Tue, 18 Jul 2023 20:20:50 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Asmaa Mnebhi <asmaa@...dia.com>
Cc: andy.shevchenko@...il.com, linus.walleij@...aro.org,
bgolaszewski@...libre.com, linux-gpio@...r.kernel.org,
linux-kernel@...r.kernel.org, davthompson@...dia.com
Subject: Re: [PATCH v2 1/1] gpio: mmio: handle "ngpios" properly in bgpio_init()
On Tue, Jul 11, 2023 at 5:13 PM Asmaa Mnebhi <asmaa@...dia.com> wrote:
>
> bgpio_init() uses "sz" argument to populate ngpio, which is not
> accurate. Instead, read the "ngpios" property from the DT and if it
> doesn't exist, use the "sz" argument. With this change, drivers no
> longer need to overwrite the ngpio variable after calling bgpio_init().
>
> If the "ngpios" property is specified, bgpio_bits is calculated
> as the round up value of ngpio. At the moment, the only requirement
> specified is that the round up value must be a multiple of 8 but
> it should also be a power of 2 because we provide accessors based
> on the bank size in bgpio_setup_accessors().
>
> Signed-off-by: Asmaa Mnebhi <asmaa@...dia.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
> ---
I'm confused. Is this the final version after all?
Bart
Powered by blists - more mailing lists