linux-kernel - Re: [PATCH v2] sparc: Explicitly include correct DT includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_Jsq+vrAhG0FqqH-_rBtL2nEbJ+v=c3QfmjzOC=1A+Qi3KdQ@mail.gmail.com>
Date:   Tue, 18 Jul 2023 13:06:25 -0600
From:   Rob Herring <robh@...nel.org>
To:     John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>
Cc:     Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        devicetree@...r.kernel.org, Sam Ravnborg <sam@...nborg.org>,
        linux-crypto@...r.kernel.org, sparclinux@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] sparc: Explicitly include correct DT includes

On Tue, Jul 18, 2023 at 8:56 AM John Paul Adrian Glaubitz
<glaubitz@...sik.fu-berlin.de> wrote:
>
> Hi Rob!
>
> On Tue, 2023-07-18 at 08:32 -0600, Rob Herring wrote:
> > The DT of_device.h and of_platform.h date back to the separate
> > of_platform_bus_type before it as merged into the regular platform bus.
> > As part of that merge prepping Arm DT support 13 years ago, they
> > "temporarily" include each other. They also include platform_device.h
> > and of.h. As a result, there's a pretty much random mix of those include
> > files used throughout the tree. In order to detangle these headers and
> > replace the implicit includes with struct declarations, users need to
> > explicitly include the correct includes.
>
> I would suggest rephrasing the subject to
>
>         sparc: Explicitly include correct DT headers
>
> as " ... include ... includes" sounds a bit awkward ;-).

Probably would have been better, but there's ~100 other patches with
the same subject. Some of those have been applied already.

Rob