linux-kernel - Re: [PATCH v5 2/4] fbdev: Move core fbdev symbols to a separate Kconfig file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 Jul 2023 21:36:30 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Javier Martinez Canillas" <javierm@...hat.com>,
        linux-kernel@...r.kernel.org
Cc:     "Geert Uytterhoeven" <geert@...ux-m68k.org>,
        "Thomas Zimmermann" <tzimmermann@...e.de>,
        "Andy Shevchenko" <andriy.shevchenko@...ux.intel.com>,
        "Daniel Vetter" <daniel@...ll.ch>, "Helge Deller" <deller@....de>,
        "Randy Dunlap" <rdunlap@...radead.org>,
        "Sam Ravnborg" <sam@...nborg.org>, dri-devel@...ts.freedesktop.org,
        linux-fbdev@...r.kernel.org
Subject: Re: [PATCH v5 2/4] fbdev: Move core fbdev symbols to a separate Kconfig file

On Fri, Jul 14, 2023, at 19:16, Javier Martinez Canillas wrote:
> The drivers/video/fbdev/Kconfig defines both symbols for fbdev drivers and
> core fbdev symbols, that can be enabled independently of the fbdev drivers.
>
> Split the Kconfig in two, one that only has the symbols for fbdev drivers
> and another one that contains the fbdev core symbols.
>
> Suggested-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Javier Martinez Canillas <javierm@...hat.com>
> ---

While testing this patch series, I noticed a conflict against
Thomas Zimmermann's series for FB_SYS_HELPERS_DEFERRED, so you'll
have to adapt the patches in order to apply them on top.

> +
> +config FB_HECUBA
> +	tristate
> +	depends on FB
> +	depends on FB_DEFERRED_IO
> +
> +config FB_SVGALIB
> +	tristate
> +	depends on FB
> +	help
> +	  Common utility functions useful to fbdev drivers of VGA-based
> +	  cards.
> +
> +config FB_MACMODES
> +	tristate
> +	depends on FB
> +

The FB_HECUBA now needs 'FB_SYS_HELPERS_DEFERRED' instead
of 'FB_DEFERRED_IO', which is the change done in the other
patch. I think the best way of doing that would be to just
not move the three symbols above to core/Kconfig but leave them
in place, as they are all just helper modules for some other
drivers, rather than core code.

      Arnd