linux-kernel - Re: [PATCH] staging: Explicitly include correct DT includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6d6c8412-1511-a780-30f9-f0cc76112e62@microchip.com>
Date:   Tue, 18 Jul 2023 04:24:55 +0000
From:   <Parthiban.Veerasooran@...rochip.com>
To:     <robh@...nel.org>
CC:     <devicetree@...r.kernel.org>, <linux-staging@...ts.linux.dev>,
        <linux-kernel@...r.kernel.org>, <greybus-dev@...ts.linaro.org>,
        <linux-media@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-amlogic@...ts.infradead.org>, <linux-sunxi@...ts.linux.dev>,
        <linux-tegra@...r.kernel.org>, <hvaibhav.linux@...il.com>,
        <johan@...nel.org>, <elder@...nel.org>, <slongerbeam@...il.com>,
        <p.zabel@...gutronix.de>, <mchehab@...nel.org>,
        <s.hauer@...gutronix.de>, <kernel@...gutronix.de>,
        <festevam@...il.com>, <gregkh@...uxfoundation.org>,
        <linux-imx@....com>, <neil.armstrong@...aro.org>,
        <khilman@...libre.com>, <jbrunet@...libre.com>,
        <martin.blumenstingl@...glemail.com>, <mripard@...nel.org>,
        <paul.kocialkowski@...tlin.com>, <wens@...e.org>,
        <jernej.skrabec@...il.com>, <samuel@...lland.org>,
        <thierry.reding@...il.com>, <jonathanh@...dia.com>,
        <skomatineni@...dia.com>, <luca.ceresoli@...tlin.com>,
        <Christian.Gromm@...rochip.com>
Subject: Re: [PATCH] staging: Explicitly include correct DT includes

On 14/07/23 11:20 pm, Rob Herring wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
> 
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
>   drivers/staging/most/dim2/dim2.c                  | 2 +-
Acked-by: Parthiban Veerasooran <parthiban.veerasooran@...rochip.com>
> 
> diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c
> index 44d3252d4612..ed6a9cc88541 100644
> --- a/drivers/staging/most/dim2/dim2.c
> +++ b/drivers/staging/most/dim2/dim2.c
> @@ -8,7 +8,6 @@
>   #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> 
>   #include <linux/module.h>
> -#include <linux/of_platform.h>
>   #include <linux/printk.h>
>   #include <linux/kernel.h>
>   #include <linux/init.h>
> @@ -21,6 +20,7 @@
>   #include <linux/sched.h>
>   #include <linux/kthread.h>
>   #include <linux/most.h>
> +#include <linux/of.h>
>   #include "hal.h"
>   #include "errors.h"
>   #include "sysfs.h"
> --
> 2.40.1
>