linux-kernel - RE: [PATCH] RDMA/irdma: fix building without IPv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MWHPR11MB0029128131B076B77BA55078E938A@MWHPR11MB0029.namprd11.prod.outlook.com>
Date:   Tue, 18 Jul 2023 21:17:18 +0000
From:   "Saleem, Shiraz" <shiraz.saleem@...el.com>
To:     Arnd Bergmann <arnd@...nel.org>,
        "Ismail, Mustafa" <mustafa.ismail@...el.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Leon Romanovsky <leon@...nel.org>
CC:     Arnd Bergmann <arnd@...db.de>,
        "Devale, Sindhu" <sindhu.devale@...el.com>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] RDMA/irdma: fix building without IPv6

> Subject: [PATCH] RDMA/irdma: fix building without IPv6
> 
> From: Arnd Bergmann <arnd@...db.de>
> 
> The new irdma_iw_get_vlan_prio() function requires IPv6 support to build:
> 
> x86_64-linux-ld: drivers/infiniband/hw/irdma/cm.o: in function
> `irdma_iw_get_vlan_prio':
> cm.c:(.text+0x2832): undefined reference to `ipv6_chk_addr'
> 
> Add a compile-time check in the same way as elsewhere in this file to avoid this by
> conditionally leaving out the ipv6 specific bits.
> 
> Fixes: f877f22ac1e9b ("RDMA/irdma: Implement egress VLAN priority")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/infiniband/hw/irdma/cm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/irdma/cm.c b/drivers/infiniband/hw/irdma/cm.c
> index 6b71b67ce9ff0..8ea55c6a3fba5 100644
> --- a/drivers/infiniband/hw/irdma/cm.c
> +++ b/drivers/infiniband/hw/irdma/cm.c
> @@ -1562,7 +1562,7 @@ static u8 irdma_iw_get_vlan_prio(u32 *loc_addr, u8
> prio, bool ipv4)
>  	rcu_read_lock();
>  	if (ipv4) {
>  		ndev = ip_dev_find(&init_net, htonl(loc_addr[0]));
> -	} else {
> +	} else if (IS_ENABLED(CONFIG_IPV6)) {
>  		struct net_device *ip_dev;
>  		struct in6_addr laddr6;
> 
> --
> 2.39.2

Acked-by: Shiraz Saleem <shiraz.saleem@...el.com>