[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87zg3sx509.ffs@tglx>
Date: Tue, 18 Jul 2023 23:51:34 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Peter Keresztes Schmidt <peter@...esztesschmidt.de>
Cc: x86@...nel.org, Linus Torvalds <torvalds@...ux-foundation.org>,
Andrew Cooper <andrew.cooper3@...rix.com>,
Tom Lendacky <thomas.lendacky@....com>,
Paolo Bonzini <pbonzini@...hat.com>,
Wei Liu <wei.liu@...nel.org>,
Arjan van de Ven <arjan@...ux.intel.com>,
LKML <linux-kernel@...r.kernel.org>,
Juergen Gross <jgross@...e.com>
Subject: Re: [patch 50/58] x86/apic: Provide common init infrastructure
On Tue, Jul 18 2023 at 23:29, Peter Keresztes Schmidt wrote:
> Hi Thomas!
>
> On 18.07.23 01:15, Thomas Gleixner wrote:
>> --- a/arch/x86/kernel/apic/bigsmp_32.c
>> +++ b/arch/x86/kernel/apic/bigsmp_32.c
>> @@ -119,10 +119,8 @@ bool __init apic_bigsmp_possible(bool cm
>>
>> void __init apic_bigsmp_force(void)
>> {
>> - if (apic != &apic_bigsmp) {
>> - apic = &apic_bigsmp;
>> - pr_info("Overriding APIC driver with bigsmp\n");
>> - }
>> + if (apic != &apic_bigsmp)
>> + apic_install_driver(&apic_noop);
>
> Could apic_noop be a typo? Shouldn't it be apic_bigsmp?
Indeed. Good catch!
Thanks,
tglx
Powered by blists - more mailing lists