linux-kernel - Re: [PATCH v2] fsi: Explicitly include correct DT includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9b4102fc-b630-8463-aa00-e7d8aab4a2be@linux.ibm.com>
Date:   Tue, 18 Jul 2023 16:57:39 -0500
From:   Eddie James <eajames@...ux.ibm.com>
To:     Rob Herring <robh@...nel.org>, Jeremy Kerr <jk@...abs.org>,
        Joel Stanley <joel@....id.au>,
        Alistar Popple <alistair@...ple.id.au>
Cc:     linux-fsi@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] fsi: Explicitly include correct DT includes


On 7/18/23 15:55, Rob Herring wrote:
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.


Thanks,

Reviewed-by: Eddie James <eajames@...ux.ibm.com>


>
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
> v2:
>   - I inadvertently had a dependency in my tree partially updating the
>     headers. That's squashed in now.
> ---
>   drivers/fsi/fsi-occ.c     | 2 +-
>   drivers/fsi/fsi-sbefifo.c | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/fsi/fsi-occ.c b/drivers/fsi/fsi-occ.c
> index abdd37d5507f..da35ca9e84a6 100644
> --- a/drivers/fsi/fsi-occ.c
> +++ b/drivers/fsi/fsi-occ.c
> @@ -15,7 +15,7 @@
>   #include <linux/mutex.h>
>   #include <linux/fsi-occ.h>
>   #include <linux/of.h>
> -#include <linux/of_device.h>
> +#include <linux/of_platform.h>
>   #include <linux/platform_device.h>
>   #include <linux/sched.h>
>   #include <linux/slab.h>
> diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c
> index 9912b7a6a4b9..4bae52c98620 100644
> --- a/drivers/fsi/fsi-sbefifo.c
> +++ b/drivers/fsi/fsi-sbefifo.c
> @@ -22,8 +22,8 @@
>   #include <linux/module.h>
>   #include <linux/mutex.h>
>   #include <linux/of.h>
> -#include <linux/of_device.h>
>   #include <linux/of_platform.h>
> +#include <linux/platform_device.h>
>   #include <linux/sched.h>
>   #include <linux/slab.h>
>   #include <linux/uaccess.h>