linux-kernel - RE: [Intel-wired-lan] [PATCH net v1] i40e:Fix an NULL vs IS_ERR() bug for debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 18 Jul 2023 05:26:58 +0000
From:   "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha@...el.com>
To:     Wang Ming <machel@...o.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        "Eric Dumazet" <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Shannon Nelson <shannon.nelson@...el.com>,
        Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "opensource.kernel@...o.com" <opensource.kernel@...o.com>
Subject: RE: [Intel-wired-lan] [PATCH net v1] i40e:Fix an NULL vs IS_ERR() bug
 for debugfs_create_dir()

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Wang Ming
> Sent: Thursday, July 13, 2023 7:13 AM
> To: Brandeburg, Jesse <jesse.brandeburg@...el.com>; Nguyen, Anthony L <anthony.l.nguyen@...el.com>; David S. Miller <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; Shannon Nelson <shannon.nelson@...el.com>; Jeff Kirsher <jeffrey.t.kirsher@...el.com>; intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; linux-kernel@...r.kernel.org
> Cc: Wang Ming <machel@...o.com>; opensource.kernel@...o.com
> Subject: [Intel-wired-lan] [PATCH net v1] i40e:Fix an NULL vs IS_ERR() bug for debugfs_create_dir()
>
> The debugfs_create_dir() function returns error pointers.
> It never returns NULL. Most incorrect error checks were fixed, but the one in i40e_dbg_init() was forgotten.
>
> Fix the remaining error check.
>
> Signed-off-by: Wang Ming <machel@...o.com>
>
> Fixes: 02e9c290814c ("i40e: debugfs interface")
> ---
> drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com> (A Contingent worker at Intel)