linux-kernel - Re: [PATCH v3 3/4] dt-bindings: soc: mediatek: pwrap: Add compatible for MT8188

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 Jul 2023 06:34:28 +0000
From:   Jason-ch Chen (陳建豪) 
        <Jason-ch.Chen@...iatek.com>
To:     "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "krzysztof.kozlowski@...aro.org" <krzysztof.kozlowski@...aro.org>,
        "conor+dt@...nel.org" <conor+dt@...nel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>
CC:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "wenst@...omium.org" <wenst@...omium.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "nfraprado@...labora.com" <nfraprado@...labora.com>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        Project_Global_Chrome_Upstream_Group 
        <Project_Global_Chrome_Upstream_Group@...iatek.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH v3 3/4] dt-bindings: soc: mediatek: pwrap: Add compatible
 for MT8188

Hi Krzysztof,

On Mon, 2023-07-17 at 21:55 +0200, Krzysztof Kozlowski wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On 17/07/2023 14:02, Jason-ch Chen wrote:
> > From: jason-ch chen <Jason-ch.Chen@...iatek.com>
> > 
> > Add MT8188 PMIC Wrapper compatible to binding document.
> 
> No improvements here - the compatible is already there. Subject has
> the
> same issue. Explain what you are doing and why.

The reason for changing the patch was that while MT8188 uses the same
pwrap as MT8195, the original code was applicable to 'compatible =
"mediatek,mt8188-pwrap"'.

To resolve the DTBS check warning that '['mediatek,mt8188-pwrap',
'mediatek,mt8195-pwrap', 'syscon'] is too long', I modified the code as
per the current patch.

> 
> > 
> > Signed-off-by: jason-ch chen <Jason-ch.Chen@...iatek.com>
> > ---
> >  .../devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml    | 6
> +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> > 
> > diff --git
> a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> > index a06ac2177444..4737e5f45d54 100644
> > ---
> a/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> > +++
> b/Documentation/devicetree/bindings/soc/mediatek/mediatek,pwrap.yaml
> > @@ -41,7 +41,6 @@ properties:
> >                - mediatek,mt8173-pwrap
> >                - mediatek,mt8183-pwrap
> >                - mediatek,mt8186-pwrap
> > -              - mediatek,mt8188-pwrap
> 
> Look, here ^^^^
> 
> >                - mediatek,mt8195-pwrap
> >                - mediatek,mt8365-pwrap
> >                - mediatek,mt8516-pwrap
> > @@ -50,6 +49,11 @@ properties:
> >                - mediatek,mt8186-pwrap
> >                - mediatek,mt8195-pwrap
> >            - const: syscon
> > +      - items:
> > +          - enum:
> > +              - mediatek,mt8188-pwrap
> 
> 
> Best regards,
> Krzysztof

Thanks,
Jason
>