linux-kernel - Re: [PATCH] KVM: x86: Fix errors & warnings in irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <34c52f9b-df4c-1b02-8419-b9b4fb18dd70@linaro.org>
Date:   Tue, 18 Jul 2023 08:46:41 +0200
From:   Philippe Mathieu-Daudé <philmd@...aro.org>
To:     shijie001@...suo.com, tglx@...utronix.de, mingo@...hat.com,
        bp@...en8.de, dave.hansen@...ux.intel.com, x86@...nel.org
Cc:     hpa@...or.com, kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: x86: Fix errors & warnings in irq_comm.c

On 12/7/23 08:21, shijie001@...suo.com wrote:

> ERROR: Macros with complex values should be enclosed in parentheses
> 
> Signed-off-by: Jie Shi <shijie001@...suo.com>
> ---
>   arch/x86/kvm/irq_comm.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)


> @@ -365,7 +367,7 @@ EXPORT_SYMBOL_GPL(kvm_intr_is_single_vcpu);
> 
>   #define PIC_ROUTING_ENTRY(irq) \
>       { .gsi = irq, .type = KVM_IRQ_ROUTING_IRQCHIP,    \
> -      .u.irqchip = { .irqchip = SELECT_PIC(irq), .pin = (irq) % 8 } }

The value is already enclosed in parentheses... False positive?

> +      .u.irqchip = { .irqchip = SELECT_PIC(irq), .pin = ((irq) % 8) } }
>   #define ROUTING_ENTRY2(irq) \
>       IOAPIC_ROUTING_ENTRY(irq), PIC_ROUTING_ENTRY(irq)