linux-kernel - Re: [PATCH] KVM: x86: Fix error & warning in i8254.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <72c44b42-0ed3-9eea-22dc-4b35b24c8ba7@linaro.org>
Date:   Tue, 18 Jul 2023 08:48:36 +0200
From:   Philippe Mathieu-Daudé <philmd@...aro.org>
To:     shijie001@...suo.com, tglx@...utronix.de, mingo@...hat.com,
        bp@...en8.de, dave.hansen@...ux.intel.com, x86@...nel.org
Cc:     hpa@...or.com, kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
        seanjc@...gle.com, pbonzini@...hat.com
Subject: Re: [PATCH] KVM: x86: Fix error & warning in i8254.h

On 12/7/23 08:02, shijie001@...suo.com wrote:
> The following checkpatch error & warning are removed:
> WARNING: please, no space before tabs
> ERROR: Macros with complex values should be enclosed in parentheses
> 
> Signed-off-by: Jie Shi <shijie001@...suo.com>
> ---
>   arch/x86/kvm/i8254.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)


>       struct mutex lock;
> @@ -52,7 +52,7 @@ struct kvm_pit {
>   #define KVM_SPEAKER_BASE_ADDRESS    0x61
>   #define KVM_PIT_MEM_LENGTH        4
>   #define KVM_PIT_FREQ            1193181
> -#define KVM_MAX_PIT_INTR_INTERVAL   HZ / 100
> +#define KVM_MAX_PIT_INTR_INTERVAL   (HZ / 100)

This looks like dead code, maybe better just remove?

>   #define KVM_PIT_CHANNEL_MASK        0x3
> 
>   struct kvm_pit *kvm_create_pit(struct kvm *kvm, u32 flags);