linux-kernel - Re: [PATCH -next] media: i2c: No need to set device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <843b7912-4e99-652a-ef3f-9fbb231c4c65@ideasonboard.com>
Date:   Tue, 18 Jul 2023 10:06:01 +0300
From:   Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     mchehab@...nel.org, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] media: i2c: No need to set device_driver owner

On 18/07/2023 04:01, Yang Li wrote:
> Remove .owner field if calls are used which set it automatically.
> 
> to silence the warning:
> ./drivers/media/i2c/ds90ub953.c:1390:3-8: No need to set .owner here.  The core will do it.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5902
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>   drivers/media/i2c/ds90ub953.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/ds90ub953.c b/drivers/media/i2c/ds90ub953.c
> index 1e3827a60029..ce1c6f8b656e 100644
> --- a/drivers/media/i2c/ds90ub953.c
> +++ b/drivers/media/i2c/ds90ub953.c
> @@ -1387,7 +1387,6 @@ static struct i2c_driver ds90ub953_driver = {
>   	.id_table	= ub953_id,
>   	.driver = {
>   		.name	= "ds90ub953",
> -		.owner = THIS_MODULE,
>   		.of_match_table = ub953_dt_ids,
>   	},
>   };

Reviewed-by: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>

  Tomi