linux-kernel - Re: [PATCH] wifi: ata: pata_parport: epat.c Added missing spaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 Jul 2023 17:00:15 +0900
From:   Damien Le Moal <dlemoal@...nel.org>
To:     hanyu001@...suo.com
Cc:     linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] wifi: ata: pata_parport: epat.c Added missing spaces

On 7/18/23 16:57, hanyu001@...suo.com wrote:
> Added spaces needed in the proper places to address:

wifi ? I do not think so. Please fix the patch title.

> 
> ./drivers/ata/pata_parport/epat.c:283: ERROR: spaces required around 
> that '=' (ctx:VxV)
> ./drivers/ata/pata_parport/epat.c:283: ERROR: space required after that 
> ';' (ctx:VxV)
> ./drivers/ata/pata_parport/epat.c:283: ERROR: spaces required around 
> that '<' (ctx:VxV)
> ./drivers/ata/pata_parport/epat.c:283: ERROR: space required after that 
> ';' (ctx:VxV)
> 
> Signed-off-by: Yu Han <hanyu001@...suo.com>
> ---
>   drivers/ata/pata_parport/epat.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ata/pata_parport/epat.c 
> b/drivers/ata/pata_parport/epat.c
> index 016bd96..efc18e2 100644
> --- a/drivers/ata/pata_parport/epat.c
> +++ b/drivers/ata/pata_parport/epat.c
> @@ -280,7 +280,7 @@ static int epat_test_proto(struct pi_adapter *pi)
>       epat_disconnect(pi);
> 
>       epat_connect(pi);
> -    for (j=0;j<2;j++) {
> +    for (j = 0; j < 2; j++) {
>           WRi(6, 0xa0 + j * 0x10);
>           for (k = 0; k < 256; k++) {
>               WRi(2, k ^ 0xaa);

-- 
Damien Le Moal
Western Digital Research