linux-kernel - Re: [PATCH v3 3/3] net: dsa: mv88e632x: Add SERDES ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bd7215b802b114b75de4568cc1642f791b233338.camel@siemens.com>
Date:   Tue, 18 Jul 2023 08:24:47 +0000
From:   "Sverdlin, Alexander" <alexander.sverdlin@...mens.com>
To:     "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "Haener, Michael" <michael.haener@...mens.com>
CC:     "andrew@...n.ch" <andrew@...n.ch>,
        "olteanv@...il.com" <olteanv@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>
Subject: Re: [PATCH v3 3/3] net: dsa: mv88e632x: Add SERDES ops

Hello Russell,

On Tue, 2023-07-18 at 08:48 +0100, Russell King (Oracle) wrote:
> On Tue, Jul 18, 2023 at 08:47:23AM +0100, Russell King (Oracle) wrote:
> > On Tue, Jul 18, 2023 at 08:59:31AM +0200, M. Haener wrote:
> > > From: Michael Haener <michael.haener@...mens.com>
> > > 
> > > The 88e632x family has several SERDES 100/1000 blocks. By adding these
> > > operations, these functionalities can be used.
> > > 
> > > Signed-off-by: Michael Haener <michael.haener@...mens.com>
> > > ---
> > > Changelog:
> > > v3: rebased onto main branch
> > > v2: rebased onto Russell Kings series dsa/88e6xxx/phylink
> > 
> > I think you're missing something - you seem to be adding support to read
> > the statistics from these blocks, but you're not actually driving them
> > at all in terms of reading their status or configuring them.
> > 
> > You need to modify drivers/net/dsa/mv88e6xxx/pcs-6352.c for that.
> 
> ... and this is why you need to be able to test on recent kernels!

are you absolutely sure about it?

mv88e6352_serdes_get_stats() remained in serdes.c after your rework and
as I see it, your rework is about link status, but you didn't touch
registers and statistics.

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com