lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <befe05762b714948ad1f71a5d038334100f84cd0.camel@redhat.com>
Date:   Tue, 18 Jul 2023 10:51:58 +0200
From:   Paolo Abeni <pabeni@...hat.com>
To:     Markus Elfring <Markus.Elfring@....de>,
        Wang Ming <machel@...o.com>, opensource.kernel@...o.com,
        netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        David Daney <david.daney@...ium.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Sunil Goutham <sgoutham@...vell.com>
Cc:     LKML <linux-kernel@...r.kernel.org>, Minjie Du <duminjie@...o.com>
Subject: Re: [PATCH net v3] net: thunder: bgx: Fix resource leaks in
 device_for_each_child_node() loops

On Fri, 2023-07-14 at 15:06 +0200, Markus Elfring wrote:
> > The device_for_each_child_node() loop in bgx_init_of_phy()
> > function should have fwnode_handle_put() before break which could
> > avoid resource leaks. This patch could fix this bug.
> 
> Are imperative change descriptions still preferred?

Yes. The commit message should be re-phrased.

More importantly, it looks like the relevant reference is already
released by of_node_put() and the additional fwnode_handle_put() will
cause a reference underflow.

This patch does not look correct to me.

Cheers,

Paolo

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ