| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 18 Jul 2023 11:04:16 +0200
From: Jean-Jacques Hiblot <jjhiblot@...phandler.com>
To: Lee Jones <lee@...nel.org>
CC: <linux-leds@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v10 3/5] leds: class: store the color index in struct
led_classdev
On 13/07/2023 11:53, Lee Jones wrote:
> On Sat, 24 Jun 2023, Jean-Jacques Hiblot wrote:
>>
>> +static ssize_t color_show(struct device *dev,
>> + struct device_attribute *attr, char *buf)
>> +{
>> + const char *color_text = "invalid";
>> + struct led_classdev *led_cdev = dev_get_drvdata(dev);
>
> Can this be NULL?
Thanks for your feedback.
No it can't be NULL.
>
>> + if (led_cdev->color < LED_COLOR_ID_MAX)
>> + color_text = led_colors[led_cdev->color];
>
> '\n'
Powered by blists - more mailing lists