linux-kernel - Re: [PATCH] firmware: arm_scmi: Fix signed error return values handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZLZfdCBEF9YWtGWa@pluto>
Date:   Tue, 18 Jul 2023 10:46:28 +0100
From:   Cristian Marussi <cristian.marussi@....com>
To:     Sukrut Bellary <sukrut.bellary@...ux.com>
Cc:     Sudeep Holla <sudeep.holla@....com>,
        Dan Carpenter <dan.carpenter@...aro.org>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] firmware: arm_scmi: Fix signed error return values
 handling

On Tue, Jul 18, 2023 at 01:55:29AM -0700, Sukrut Bellary wrote:
> Handle signed error return values returned by simple_write_to_buffer().
> In case of an error, return the error code.
> 
> Fixes: 3c3d818a9317 ("firmware: arm_scmi: Add core raw transmission support")
> Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
> Signed-off-by: Sukrut Bellary <sukrut.bellary@...ux.com>
> ---
> This is based on static analysis. Compilation tested.
> ---

Hi Sukrut,

thanks for this.

Reviewed-by: Cristian Marussi <cristian.marussi@....com>
Tested-by: Cristian Marussi <cristian.marussi@....com>

Thanks,
Cristian