linux-kernel - Re: [PATCH] ata: space required after that ','

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 18 Jul 2023 19:49:12 +0900
From:   Damien Le Moal <dlemoal@...nel.org>
To:     hanyu001@...suo.com
Cc:     linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ata: space required after that ','

On 7/18/23 18:48, hanyu001@...suo.com wrote:
> Fixes the following checkpatch errors:

Same comment as in my previous email. What patch triggers this ?
Yes it is a bad code style and changing the code in that area will definitely
trigger warnings with checkpatch. But you are not changing anything...
So let's avoid churn please. If you actually fix something in that area, then
OK, add this syntax change as well.

> 
> ./drivers/ata/libata-transport.c:92: ERROR: space required after that 
> ',' (ctx:VxV)
> ./drivers/ata/libata-transport.c:92: ERROR: space required after that 
> ',' (ctx:VxV)
> ./drivers/ata/libata-transport.c:92: ERROR: space required after that 
> ',' (ctx:VxV)
> ./drivers/ata/libata-transport.c:92: ERROR: space required after that 
> ',' (ctx:VxV)
> ./drivers/ata/libata-transport.c:94: ERROR: space required after that 
> ',' (ctx:VxV)
> ./drivers/ata/libata-transport.c:94: ERROR: space required after that 
> ',' (ctx:VxV)
> ./drivers/ata/libata-transport.c:94: ERROR: space required after that 
> ',' (ctx:VxV)
> 
> Signed-off-by: Yu Han <	hanyu001@...suo.com>
> ---
>   drivers/ata/libata-transport.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/ata/libata-transport.c 
> b/drivers/ata/libata-transport.c
> index e4fb9d1..4e87f77 100644
> --- a/drivers/ata/libata-transport.c
> +++ b/drivers/ata/libata-transport.c
> @@ -89,9 +89,9 @@ struct ata_internal {
>   /*
>    * Hack to allow attributes of the same name in different objects.
>    */
> -#define ATA_DEVICE_ATTR(_prefix,_name,_mode,_show,_store) \
> +#define ATA_DEVICE_ATTR(_prefix, _name, _mode, _show, _store) \
>       struct device_attribute device_attr_##_prefix##_##_name = \
> -    __ATTR(_name,_mode,_show,_store)
> +    __ATTR(_name, _mode, _show, _store)
> 
>   #define ata_bitfield_name_match(title, table)            \
>   static ssize_t                            \

-- 
Damien Le Moal
Western Digital Research