linux-kernel - Re: [net PATCH] octeontx2-af: Adjust Tx credits when MCS external bypass is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <02b2a11c2990fdf21e8cd2c582df67d5883f6eea.camel@redhat.com>
Date:   Tue, 18 Jul 2023 13:08:30 +0200
From:   Paolo Abeni <pabeni@...hat.com>
To:     Geetha sowjanya <gakula@...vell.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     kuba@...nel.org, davem@...emloft.net, edumazet@...gle.com,
        sgoutham@...vell.com, sbhatta@...vell.com, hkelam@...vell.com,
        ndabilpuram@...vell.com
Subject: Re: [net PATCH] octeontx2-af: Adjust Tx credits when MCS external
 bypass is disabled

On Sun, 2023-07-16 at 14:46 +0530, Geetha sowjanya wrote:
> From: Nithin Dabilpuram <ndabilpuram@...vell.com>
> 
> When MCS external bypass is disabled, MCS returns additional
> 2 credits(32B) for every packet Tx'ed on LMAC. To account for
> these extra credits, NIX_AF_TX_LINKX_NORM_CREDIT.CC_MCS_CNT
> needs to be configured as otherwise NIX Tx credits would overflow
> and will never be returned to idle state credit count
> causing issues with credit control and MTU change.
> 
> This patch fixes the same by configuring CC_MCS_CNT at probe
> time for MCS enabled SoC's
> 
> Fixes: bd69476e86fc ("octeontx2-af: cn10k: mcs: Install a default TCAM for normal traffic")
> Signed-off-by: Nithin Dabilpuram <ndabilpuram@...vell.com>
> Signed-off-by: Geetha sowjanya <gakula@...vell.com>
> Signed-off-by: Sunil Goutham <sgoutham@...vell.com>
> ---
>  drivers/net/ethernet/marvell/octeontx2/af/mbox.h    |  2 +-
>  drivers/net/ethernet/marvell/octeontx2/af/mcs.c     | 12 ++++++++++++
>  drivers/net/ethernet/marvell/octeontx2/af/mcs.h     |  2 ++
>  drivers/net/ethernet/marvell/octeontx2/af/rvu.h     |  1 +
>  drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c |  8 ++++++++
>  5 files changed, 24 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/marvell/octeontx2/af/mbox.h b/drivers/net/ethernet/marvell/octeontx2/af/mbox.h
> index eba307eee2b2..d78d72c0ca18 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/af/mbox.h
> +++ b/drivers/net/ethernet/marvell/octeontx2/af/mbox.h
> @@ -1914,7 +1914,7 @@ struct mcs_hw_info {
>  	u8 tcam_entries;	/* RX/TX Tcam entries per mcs block */
>  	u8 secy_entries;	/* RX/TX SECY entries per mcs block */
>  	u8 sc_entries;		/* RX/TX SC CAM entries per mcs block */
> -	u8 sa_entries;		/* PN table entries = SA entries */
> +	u16 sa_entries;		/* PN table entries = SA entries */

This chunk looks like an unrelated bug-fix. Please move it to a
separate patch or mention in the commit message why it's needed here.

Thanks!

Paolo