linux-kernel - Re: [PATCH 3/3] arm64: dts: Add node for chip info driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b3813aeb-8650-e406-eee6-05658ba568ff@linaro.org>
Date:   Tue, 18 Jul 2023 13:47:06 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     William-tw Lin <william-tw.lin@...iatek.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Kevin Hilman <khilman@...nel.org>
Cc:     Project_Global_Chrome_Upstream_Group@...iatek.com,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH 3/3] arm64: dts: Add node for chip info driver

On 18/07/2023 13:21, William-tw Lin wrote:
> Add dts node for socinfo retrieval. This includes the following projects:
> MT8173
> MT8183
> MT8186
> MT8192
> MT8195
> 
> Signed-off-by: William-tw Lin <william-tw.lin@...iatek.com>
> ---
>  arch/arm64/boot/dts/mediatek/mt8173.dtsi | 15 +++++++++++++++
>  arch/arm64/boot/dts/mediatek/mt8183.dtsi | 15 +++++++++++++++
>  arch/arm64/boot/dts/mediatek/mt8186.dtsi | 10 ++++++++++
>  arch/arm64/boot/dts/mediatek/mt8192.dtsi | 14 ++++++++++++++
>  arch/arm64/boot/dts/mediatek/mt8195.dtsi |  9 +++++++++
>  5 files changed, 63 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> index c47d7d900f28..115f907751c1 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> @@ -590,11 +590,26 @@
>  			reg = <0 0x10206000 0 0x1000>;
>  			#address-cells = <1>;
>  			#size-cells = <1>;
> +
> +			socinfo_data1: socinfo-data1 {
> +				reg = <0x040 0x4>;
> +			};
> +
> +			socinfo_data2: socinfo-data2 {
> +				reg = <0x044 0x4>;
> +			};
> +
>  			thermal_calibration: calib@528 {
>  				reg = <0x528 0xc>;
>  			};
>  		};
>  
> +		mtk_socinfo: mtk-socinfo {

Why do you put non-MMIO nodes in MMIO bus?

It does not look like you tested the DTS against bindings. Please run
`make dtbs_check` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).

Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

Best regards,
Krzysztof