linux-kernel - Re: [PATCH V2 10/13] remoteproc: qcom: Add Hexagon based multipd rproc driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d038e912-9917-e581-c42c-bca712687734@quicinc.com>
Date:   Tue, 18 Jul 2023 17:40:24 +0530
From:   Manikanta Mylavarapu <quic_mmanikan@...cinc.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        <agross@...nel.org>, <andersson@...nel.org>,
        <konrad.dybcio@...aro.org>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
        <jassisinghbrar@...il.com>, <mathieu.poirier@...aro.org>,
        <mturquette@...libre.com>, <sboyd@...nel.org>,
        <quic_eberman@...cinc.com>, <quic_mojha@...cinc.com>,
        <kvalo@...nel.org>, <loic.poulain@...aro.org>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-remoteproc@...r.kernel.org>,
        <linux-clk@...r.kernel.org>
CC:     <quic_srichara@...cinc.com>, <quic_sjaganat@...cinc.com>,
        <quic_kathirav@...cinc.com>, <quic_anusha@...cinc.com>,
        <quic_poovendh@...cinc.com>, <quic_varada@...cinc.com>,
        <quic_devipriy@...cinc.com>
Subject: Re: [PATCH V2 10/13] remoteproc: qcom: Add Hexagon based multipd
 rproc driver



On 7/1/2023 4:25 PM, Krzysztof Kozlowski wrote:
> On 30/06/2023 12:29, Manikanta Mylavarapu wrote:
>>
>>
>> On 6/27/2023 6:09 PM, Manikanta Mylavarapu wrote:
>>>
>>>
> 
> Do you see the lines above? You quote my reply and claim it is you who
> wrote it.
> 
> Please fix your mailer, it's making discussions unnecessary difficult.
> 
> 

Sure, i will correct it.

>>>>> +      Say y here to support the Qualcomm Secure Peripheral Image Loader
>>>>> +      for the Hexagon based MultiPD model remote processors on e.g.
>>>>> IPQ5018.
>>>>> +      This is trustZone wireless subsystem.
>>>>> +
>>>>
>>>> ...
>>>>
>> 	I didn't understand. Can you please elaborate your comment?
> 
> https://en.wikipedia.org/wiki/Ellipsis
> 
Got it.

>>
>>>>> +    int (*powerup_scm)(u32 peripheral);
>>>>> +    int (*powerdown_scm)(u32 peripheral);
>>>>> +};
>>>>> +
>>>>> +/**
>>>>> + * qcom_get_pd_asid() - get the pd asid number from DT node
>>>>
>>>>   From node name? NAK. It does not work like that. Node names can change
>>>> and you did not define this number as part of ABI.
>>>>
>>>> Probably you wanted unit address.
>>>>
>>
>> 	Yeah i got your point. Each of the WCSS PD's are internally
>> 	represented in Q6 with their corresponding "spawn" bit numbers.
>> 	I will use same and remove the "PD-" hardcodings.
>>
>> 	Is this fine ?
> 
> I don't get what you are going to use, so post a patch. Talk is cheap.
> 
> 
Sure, i posted a patch. Patch available here
https://lore.kernel.org/linux-arm-msm/20230718120501.3205661-10-quic_mmanikan@quicinc.com/

Thanks & Regards,
Manikanta.

> Best regards,
> Krzysztof
>