linux-kernel - Re: [PATCH 1/4] KVM: selftests: Rename the ASSERT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e324e61f-5fbf-4055-f570-63cb120c1bdc@linaro.org>
Date:   Tue, 18 Jul 2023 14:26:57 +0200
From:   Philippe Mathieu-Daudé <philmd@...aro.org>
To:     Thomas Huth <thuth@...hat.com>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, Paolo Bonzini <pbonzini@...hat.com>,
        Sean Christopherson <seanjc@...gle.com>
Cc:     linux-kselftest@...r.kernel.org,
        David Matlack <dmatlack@...gle.com>
Subject: Re: [PATCH 1/4] KVM: selftests: Rename the ASSERT_EQ macro

On 12/7/23 09:59, Thomas Huth wrote:
> There is already an ASSERT_EQ macro in the file
> tools/testing/selftests/kselftest_harness.h, so we currently
> can't include test_util.h from the KVM selftests together with
> that file. Rename the macro in the KVM selftests to TEST_ASSERT_EQ
> to avoid the problem - it is also more similar to the other macros
> in test_util.h that way.
> 
> Suggested-by: Sean Christopherson <seanjc@...gle.com>
> Signed-off-by: Thomas Huth <thuth@...hat.com>
> ---
>   .../selftests/kvm/aarch64/aarch32_id_regs.c   |  8 +--
>   .../selftests/kvm/aarch64/page_fault_test.c   | 10 +--
>   .../testing/selftests/kvm/include/test_util.h |  4 +-
>   tools/testing/selftests/kvm/lib/kvm_util.c    |  2 +-
>   .../selftests/kvm/max_guest_memory_test.c     |  2 +-
>   tools/testing/selftests/kvm/s390x/cmma_test.c | 62 +++++++++----------
>   tools/testing/selftests/kvm/s390x/memop.c     |  6 +-
>   tools/testing/selftests/kvm/s390x/tprot.c     |  4 +-
>   .../x86_64/dirty_log_page_splitting_test.c    | 18 +++---
>   .../x86_64/exit_on_emulation_failure_test.c   |  2 +-
>   .../kvm/x86_64/nested_exceptions_test.c       | 12 ++--
>   .../kvm/x86_64/recalc_apic_map_test.c         |  6 +-
>   .../selftests/kvm/x86_64/tsc_msrs_test.c      | 32 +++++-----
>   .../vmx_exception_with_invalid_guest_state.c  |  2 +-
>   .../selftests/kvm/x86_64/vmx_pmu_caps_test.c  |  3 +-
>   .../selftests/kvm/x86_64/xapic_state_test.c   |  8 +--
>   .../selftests/kvm/x86_64/xen_vmcall_test.c    | 20 +++---
>   17 files changed, 101 insertions(+), 100 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@...aro.org>