[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <06241e10-e7f6-64c8-ef9a-1336d56b21b8@huawei.com>
Date: Tue, 18 Jul 2023 20:56:45 +0800
From: "zhangpeng (AS)" <zhangpeng362@...wei.com>
To: Matthew Wilcox <willy@...radead.org>
CC: <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>,
<sidhartha.kumar@...cle.com>, <akpm@...ux-foundation.org>,
<wangkefeng.wang@...wei.com>, <sunnanyong@...wei.com>
Subject: Re: [PATCH 5/6] mm/page_io: convert count_swpout_vm_event() to take
in a folio
On 2023/7/17 21:48, Matthew Wilcox wrote:
> On Mon, Jul 17, 2023 at 09:26:01PM +0800, Peng Zhang wrote:
>> -static inline void count_swpout_vm_event(struct page *page)
>> +static inline void count_swpout_vm_event(struct folio *folio)
>> {
>> #ifdef CONFIG_TRANSPARENT_HUGEPAGE
>> - if (unlikely(PageTransHuge(page)))
>> + if (unlikely(folio_test_large(folio)))
>> count_vm_event(THP_SWPOUT);
>> #endif
> Since this is a THP_SWPOUT event, we should do this as:
>
> -#ifdef CONFIG_TRANSPARENT_HUGEPAGE
> - if (unlikely(PageTransHuge(page)))
> + if (folio_test_pmd_mappable(folio))
> count_vm_event(THP_SWPOUT);
> -#endif
Agreed. I'll convert PageTransHuge to folio_test_pmd_mappable.
--
Best Regards,
Peng
Powered by blists - more mailing lists