linux-kernel - Re: [PATCH] wifi: av7110: remove space before ')'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2023071830-quotation-gaining-8cbe@gregkh>
Date:   Tue, 18 Jul 2023 15:32:58 +0200
From:   Greg KH <greg@...ah.com>
To:     hanyu001@...suo.com
Cc:     mchehab@...nel.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, linux-media@...r.kernel.org
Subject: Re: [PATCH] wifi: av7110: remove space before ')'

On Tue, Jul 18, 2023 at 03:27:58PM +0800, hanyu001@...suo.com wrote:
> The patch fixes the following errors detected by checkpatch.pl:
> 
> ./drivers/staging/media/av7110/av7110.c:2556: ERROR: space prohibited before
> that close parenthesis ')'
> ./drivers/staging/media/av7110/av7110.c:2558: ERROR: space prohibited before
> that close parenthesis ')'
> ./drivers/staging/media/av7110/av7110.c:2599: ERROR: space prohibited before
> that close parenthesis ')'
> 
> Signed-off-by: Yu Han <hanyu001@...suo.com>
> ---
>  drivers/staging/media/av7110/av7110.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/media/av7110/av7110.c
> b/drivers/staging/media/av7110/av7110.c
> index a5a431c1..6b9df2c 100644
> --- a/drivers/staging/media/av7110/av7110.c
> +++ b/drivers/staging/media/av7110/av7110.c
> @@ -2553,9 +2553,9 @@ static int av7110_attach(struct saa7146_dev* dev,
>           * use 0x03 to track RPS1 interrupts - increase by 1 every gpio3 is
> toggled
>           * use 0x15 to track VPE  interrupts - increase by 1 every vpeirq()
> is called
>           */
> -        saa7146_write(dev, EC1SSR, (0x03<<2) | 3 );
> +        saa7146_write(dev, EC1SSR, (0x03<<2) | 3);
>          /* set event counter 1 threshold to maximum allowed value
> (rEC p55) */
> -        saa7146_write(dev, ECT1R,  0x3fff );
> +        saa7146_write(dev, ECT1R,  0x3fff);
>  #endif
>          /* Setup BUDGETPATCH MAIN RPS1 "program" (p35) */
>          count = 0;
> @@ -2596,7 +2596,7 @@ static int av7110_attach(struct saa7146_dev* dev,
>           * then RPS_THRESH1 should be set to trigger
>           * every TS_HEIGHT (512) lines.
>           */
> -        saa7146_write(dev, RPS_THRESH1, (TS_HEIGHT*1) | MASK_12 );
> +        saa7146_write(dev, RPS_THRESH1, (TS_HEIGHT*1) | MASK_12);
> 
>          /* Enable RPS1
> (rFC p33) */
>          saa7146_write(dev, MC1, (MASK_13 | MASK_29));
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch contains warnings and/or errors noticed by the
  scripts/checkpatch.pl tool.

- Your patch is malformed (tabs converted to spaces, linewrapped, etc.)
  and can not be applied.  Please read the file,
  Documentation/process/email-clients.rst in order to fix this.

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/process/submitting-patches.rst for what is needed in
  order to properly describe the change.

- You did not write a descriptive Subject: for the patch, allowing Greg,
  and everyone else, to know what this patch is all about.  Please read
  the section entitled "The canonical patch format" in the kernel file,
  Documentation/process/submitting-patches.rst for what a proper
  Subject: line should look like.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot