linux-kernel - Re: [PATCH drm-next v7 02/13] drm: manager to keep track of GPUs VA mappings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51968407-c87a-e565-28f7-868a1b923d5c@redhat.com>
Date:   Tue, 18 Jul 2023 13:38:48 +0200
From:   Danilo Krummrich <dakr@...hat.com>
To:     Donald Robson <Donald.Robson@...tec.com>,
        "corbet@....net" <corbet@....net>,
        "jason@...kstrand.net" <jason@...kstrand.net>,
        "willy@...radead.org" <willy@...radead.org>,
        "christian.koenig@....com" <christian.koenig@....com>,
        "tzimmermann@...e.de" <tzimmermann@...e.de>,
        "bagasdotme@...il.com" <bagasdotme@...il.com>,
        "mripard@...nel.org" <mripard@...nel.org>,
        "matthew.brost@...el.com" <matthew.brost@...el.com>,
        "bskeggs@...hat.com" <bskeggs@...hat.com>,
        "ogabbay@...nel.org" <ogabbay@...nel.org>,
        "boris.brezillon@...labora.com" <boris.brezillon@...labora.com>,
        "Liam.Howlett@...cle.com" <Liam.Howlett@...cle.com>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        "alexdeucher@...il.com" <alexdeucher@...il.com>,
        "airlied@...il.com" <airlied@...il.com>
Cc:     "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "nouveau@...ts.freedesktop.org" <nouveau@...ts.freedesktop.org>,
        "airlied@...hat.com" <airlied@...hat.com>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "thomas.hellstrom@...ux.intel.com" <thomas.hellstrom@...ux.intel.com>
Subject: Re: [PATCH drm-next v7 02/13] drm: manager to keep track of GPUs VA
 mappings

On 7/17/23 12:00, Donald Robson wrote:
> Hi Danilo,
> The below part of the documentation is out of date now.
> Thanks,
> Donald

Thanks Donald for pointing this out.

If there aren't any further objections in general I will fix up the 
comment and then push the GPUVA Manager parts of the series to 
drm-misc-next.

- Danilo

> 
> On Thu, 2023-07-13 at 19:03 +0200, Danilo Krummrich wrote:
>>
>> +
>> +/**
>> + * DOC: Locking
>> + *
>> + * Generally, the GPU VA manager does not take care of locking itself, it is
>> + * the drivers responsibility to take care about locking. Drivers might want to
>> + * protect the following operations: inserting, removing and iterating
>> + * &drm_gpuva objects as well as generating all kinds of operations, such as
>> + * split / merge or prefetch.
>> + *
>> + * The GPU VA manager also does not take care of the locking of the backing
>> + * &drm_gem_object buffers GPU VA lists by itself; drivers are responsible to
>> + * enforce mutual exclusion using either the GEMs dma_resv lock or alternatively
>> + * a driver specific external lock by setting the @DRM_GPUVA_MANAGER_LOCK_EXTERN
>> + * flag.
>> + *
>> + * For the latter, functions such as drm_gpuva_link() or drm_gpuva_unlink()
>> + * contain lockdep checks to indicate locking issues. For this to work drivers
>> + * must provide (in case the @DRM_GPUVA_MANAGER_LOCK_EXTERN flag is set) their
>> + * external lock with drm_gpuva_manager_set_ext_lock() after initialization.
>> + */
>>