[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f75bb80a-e49c-24e5-c897-7c4ecc804f84@amd.com>
Date: Tue, 18 Jul 2023 08:49:55 -0500
From: Carlos Bilbao <carlos.bilbao@....com>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: corbet@....net, ojeda@...nel.org, jani.nikula@...ux.intel.com,
rdunlap@...radead.org, linux-doc@...r.kernel.org,
linux-kernel@...r.kernel.org, konstantin@...uxfoundation.org,
Akira Yokosawa <akiyks@...il.com>,
rust-for-linux <rust-for-linux@...r.kernel.org>
Subject: Re: [PATCH v7 1/2] docs: Move rustdoc output, cross-reference it
On 7/17/23 11:37, Miguel Ojeda wrote:
> On Mon, Jul 17, 2023 at 5:16 PM Carlos Bilbao <carlos.bilbao@....com> wrote:
>>
>> +# Where to place rustdoc generated documentation
>> +RUSTDOC_OUTPUT = $(objtree)/Documentation/output/rust/rustdoc
>
> I think we may be able to get away with just `:=` instead of `=`.
Yes, for v8 we can simply use `:=`.
>
> Also, I assume this is intended to be overridable by the user, right?
> i.e. that is why you wrote the identifier as uppercase.
That's true, I don't see any reason to make this uppercase.
>
> In addition, I thought about basing it on `BUILDDIR` from the Doc's
> `Makefile`, but that probably needs moving that one so that we can
> access it here (in the case where we are not building as part of
> `htmldocs`), and thus maybe it is not worth it.
>
> (Cc'ing the rust-for-linux list, by the way)
Thanks for CC'ing, I should have done it.
>
> Cheers,
> Miguel
Thanks,
Carlos
Powered by blists - more mailing lists