linux-kernel - Re: [PATCH v2] Bluetooth: hci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230719153833.GH14791@linux-l9pv.suse>
Date:   Wed, 19 Jul 2023 23:38:33 +0800
From:   joeyli <jlee@...e.com>
To:     Paul Menzel <pmenzel@...gen.mpg.de>
Cc:     Chun-Yi Lee <joeyli.kernel@...il.com>,
        Marcel Holtmann <marcel@...tmann.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        linux-kernel@...r.kernel.org,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        Markus Elfring <Markus.Elfring@....de>,
        Dan Carpenter <dan.carpenter@...aro.org>,
        linux-bluetooth@...r.kernel.org
Subject: Re: [PATCH v2] Bluetooth: hci_event: Ignore NULL link key

Hi Paul, 

Thanks for your review!

On Tue, Jul 18, 2023 at 07:40:37AM +0200, Paul Menzel wrote:
> Dear Chun-Yi,
> 
> 
> Thank you for your patch.
> 
> Am 18.07.23 um 05:43 schrieb Lee, Chun-Yi <joeyli.kernel@...il.com>:
> 
> […]
> 
> > Signed-off-by: "Lee, Chun-Yi" <jlee@...e.com>
> 
> As checkpatch.pl also reports, please make sure the author and Signed-off-by
> entry match.
> 
>     $ git config --global user.name "Chun-Yi  Lee"
>     $ git commit --amend --author="Chun-Yi Lee <jlee@...e.com>" -s
> 
> (It’s also common to write the name in the order, so no comma is needed.)
> 
> `git format-patch` should not generate a patch with a dedicated `From:` at
> the beginning, so you can send it from a different email account. (No idea,
> why upstream Linux kernel development shouldn’t work with your SUSE
> address.)
>

I have set the from in .gitconfig and also tried git send-email --from "Lee, Chun-Yi <jlee@...e.com>".
But gmail always modified it to From: Lee, Chun-Yi <joeyli.kernel@...il.com>. I have no idea why.

In next version, I will put Signed-off-by: "Lee, Chun-Yi" <joeyli.kernel@...il.com>
to keep the From: to be sync with Signed-off-by.

Thanks a lot!
Joey Lee