linux-kernel - Re: [PATCH 3/4] dt-bindings: pinctrl-zynqmp: Add output-enable configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230719-brunette-prelaw-1c154002de1e@spud>
Date:   Wed, 19 Jul 2023 17:02:30 +0100
From:   Conor Dooley <conor@...nel.org>
To:     "Potthuri, Sai Krishna" <sai.krishna.potthuri@....com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        "Simek, Michal" <michal.simek@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        "Shah, Tanmay" <tanmay.shah@....com>,
        "Levinsky, Ben" <ben.levinsky@....com>,
        Marek Vasut <marex@...x.de>,
        Roman Gushchin <roman.gushchin@...ux.dev>,
        Arnd Bergmann <arnd@...db.de>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "saikrishna12468@...il.com" <saikrishna12468@...il.com>,
        "git (AMD-Xilinx)" <git@....com>
Subject: Re: [PATCH 3/4] dt-bindings: pinctrl-zynqmp: Add output-enable
 configuration

On Wed, Jul 19, 2023 at 06:49:43AM +0000, Potthuri, Sai Krishna wrote:
> Hi Conor,
> 
> > -----Original Message-----
> > From: Conor Dooley <conor@...nel.org>
> > Sent: Tuesday, July 18, 2023 9:20 PM
> > To: Potthuri, Sai Krishna <sai.krishna.potthuri@....com>
> > Cc: Linus Walleij <linus.walleij@...aro.org>; Simek, Michal
> > <michal.simek@....com>; Rob Herring <robh+dt@...nel.org>; Krzysztof
> > Kozlowski <krzysztof.kozlowski+dt@...aro.org>; Conor Dooley
> > <conor+dt@...nel.org>; Mathieu Poirier <mathieu.poirier@...aro.org>; Shah,
> > Tanmay <tanmay.shah@....com>; Levinsky, Ben <ben.levinsky@....com>;
> > Marek Vasut <marex@...x.de>; Roman Gushchin <roman.gushchin@...ux.dev>;
> > Arnd Bergmann <arnd@...db.de>; linux-arm-kernel@...ts.infradead.org; linux-
> > kernel@...r.kernel.org; linux-gpio@...r.kernel.org; devicetree@...r.kernel.org;
> > saikrishna12468@...il.com; git (AMD-Xilinx) <git@....com>
> > Subject: Re: [PATCH 3/4] dt-bindings: pinctrl-zynqmp: Add output-enable
> > configuration
> > 
> > On Mon, Jul 17, 2023 at 03:03:46PM +0530, Sai Krishna Potthuri wrote:
> > > Add 'output-enable' configuration parameter to the properties list.
> > >
> > > Using these pinctrl properties observed hang issues with older Xilinx
> > > ZynqMP Platform Management Firmware, hence reverted the patch previously.
> > > Commit ff8356060e3a5e126abb ("Revert "dt-bindings: pinctrl-zynqmp: Add
> > > output-enable configuration"").
> > 
> > And what has changed since then that makes it okay to add?
> > Is the old firmware not still in the wild?
> This time when Linux firmware driver get the request for TRISTATE configuration
> from pinctrl driver, it checks if that configuration is supported by the Xilinx ZynqMP
> Platform Management firmware. If yes, then calls will be made otherwise it returns error.

Please put that information in your commit message. With that done,
Acked-by: Conor Dooley <conor.dooley@...rochip.com>

Thanks,
Conor.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)