linux-kernel - Re: [PATCH V1 5/5] ASoC: dt-bindings: Add schema for "awinic,aw88261"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230719030252.41396-1-wangweidong.a@awinic.com>
Date:   Wed, 19 Jul 2023 11:02:52 +0800
From:   wangweidong.a@...nic.com
To:     krzysztof.kozlowski@...aro.org
Cc:     alsa-devel@...a-project.org, broonie@...nel.org,
        ckeepax@...nsource.cirrus.com, colin.i.king@...il.com,
        conor+dt@...nel.org, devicetree@...r.kernel.org,
        doug@...morgal.com, fido_max@...ox.ru, flatmax@...tmax.com,
        herve.codina@...tlin.com, kiseok.jo@...ndevice.com,
        krzysztof.kozlowski+dt@...aro.org, lgirdwood@...il.com,
        linux-kernel@...r.kernel.org, liweilei@...nic.com, perex@...ex.cz,
        pierre-louis.bossart@...ux.intel.com, rf@...nsource.cirrus.com,
        robh+dt@...nel.org, shumingf@...ltek.com, tiwai@...e.com,
        trix@...hat.com, wangweidong.a@...nic.com, yijiangtao@...nic.com,
        zhangjianming@...nic.com
Subject: Re: [PATCH V1 5/5] ASoC: dt-bindings: Add schema for "awinic,aw88261"

Hi, Krzysztof,
Thank you very much for your advice.

On 18/07/2023 16:24, krzysztof.kozlowski@...aro.org wrote:
> On 17/07/2023 13:58, wangweidong.a@...nic.com wrote:
>> From: Weidong Wang <wangweidong.a@...nic.com>
>> 
>> Add a DT schema for describing Awinic aw88261 audio amplifiers. They are
>> controlled using I2C.
>> 
>> Signed-off-by: Weidong Wang <wangweidong.a@...nic.com>

...

>> +  compatible:
>> +    const: awinic,aw88261
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  '#sound-dai-cells':
>> +    const: 0
>> +
>> +  reset-gpios:
>> +    maxItems: 1
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - '#sound-dai-cells'
>> +  - reset-gpios

> I don't see any differences against AW88395. Add the compatible to that
> schema.

I will add "awinic,aw88261" to the awinic,aw88395.yaml

Best regards,
Weidong Wang