linux-kernel - Re: [PATCH] scsi/sg: fix checking return value of blk_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ac099071-a16d-46a4-a1b1-2cc786a0a337@kernel.dk>
Date:   Wed, 19 Jul 2023 10:34:11 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Yu Kuai <yukuai1@...weicloud.com>, mhartmay@...ux.ibm.com,
        bblock@...ux.ibm.com, bvanassche@....org, hch@....de
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        "yukuai (C)" <yukuai3@...wei.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
Subject: Re: [PATCH] scsi/sg: fix checking return value of blk_get_queue()

On 7/18/23 7:09?PM, Yu Kuai wrote:
> Hi, Jens
> 
> ? 2023/07/05 10:40, Yu Kuai ??:
>> From: Yu Kuai <yukuai3@...wei.com>
>>
>> Commit fcaa174a9c99 ("scsi/sg: don't grab scsi host module reference")
>> make a mess how blk_get_queue() is called, blk_get_queue() returns true
>> on success while the caller expects it returns 0 on success.
>>
>> Fix this problem and also add a corresponding error message on failure.
>>
>> Fixes: fcaa174a9c99 ("scsi/sg: don't grab scsi host module reference")
>> Reported-by: Marc Hartmayer <mhartmay@...ux.ibm.com>
>> Closes: https://lore.kernel.org/all/87lefv622n.fsf@linux.ibm.com/
>> Signed-off-by: Yu Kuai <yukuai3@...wei.com>
> 
> Sorry about the trouble... Can you apply this patch? I notice that the
> original patch is applied to stable.

I can, I had assumed that Martin would pick it up on the SCSI side?

-- 
Jens Axboe