linux-kernel - Re: [PATCH v4 2/2] regulator: rtq2208: Add Richtek RTQ2208 SubPMIC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9eb5d3a3-ba26-4e68-9324-9f1ce24418b9@sirena.org.uk>
Date:   Wed, 19 Jul 2023 18:08:18 +0100
From:   Mark Brown <broonie@...nel.org>
To:     alina_yu@...htek.com
Cc:     lgirdwood@...il.com, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v4 2/2] regulator: rtq2208: Add Richtek RTQ2208 SubPMIC
 driver

On Wed, Jul 19, 2023 at 05:24:46PM +0800, alina_yu@...htek.com wrote:
> From: alinayu <alina_yu@...htek.com>
> 

It'd be better to format this like you do in your e-mail and signoff so
that git doesn't generate the extra line and the logs look a bit neater
(there might also be some warnings about signoffs due to the mismatch).
'git commit --amend --author=' should help.

> Add support for the RTQ2208 SubPMIC
> This ic integrates with configurable, synchrnous buck converters and two ldos.

The driver looks good, just needs the bindings sorting.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)