linux-kernel - Re: [PATCH] scsi: qla4xxx: Convert snprintf to scnprintf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 19 Jul 2023 11:14:25 -0700
From:   Chris Leech <cleech@...hat.com>
To:     hanyu001@...suo.com
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: qla4xxx: Convert snprintf to scnprintf

On Mon, Jul 17, 2023 at 02:18:31PM +0800, hanyu001@...suo.com wrote:
> Fix the following coccicheck warnings:
> 
> ./drivers/scsi/qla4xxx/ql4_attr.c:200:8-16: WARNING: use scnprintf or
> sprintf
> ./drivers/scsi/qla4xxx/ql4_attr.c:273:8-16: WARNING: use scnprintf or
> sprintf
> ./drivers/scsi/qla4xxx/ql4_attr.c:281:8-16: WARNING: use scnprintf or
> sprintf
> ./drivers/scsi/qla4xxx/ql4_attr.c:303:8-16: WARNING: use scnprintf or
> sprintf
> ./drivers/scsi/qla4xxx/ql4_attr.c:210:8-16: WARNING: use scnprintf or
> sprintf
> ./drivers/scsi/qla4xxx/ql4_attr.c:264:8-16: WARNING: use scnprintf or
> sprintf
> ./drivers/scsi/qla4xxx/ql4_attr.c:312:8-16: WARNING: use scnprintf or
> sprintf
> ./drivers/scsi/qla4xxx/ql4_attr.c:159:9-17: WARNING: use scnprintf or
> sprintf
> ./drivers/scsi/qla4xxx/ql4_attr.c:256:8-16: WARNING: use scnprintf or
> sprintf
> ./drivers/scsi/qla4xxx/ql4_attr.c:247:8-16: WARNING: use scnprintf or
> sprintf
> ./drivers/scsi/qla4xxx/ql4_attr.c:181:8-16: WARNING: use scnprintf or
> sprintf
> ./drivers/scsi/qla4xxx/ql4_attr.c:190:8-16: WARNING: use scnprintf or
> sprintf
> ./drivers/scsi/qla4xxx/ql4_attr.c:223:8-16: WARNING: use scnprintf or
> sprintf
> ./drivers/scsi/qla4xxx/ql4_attr.c:235:8-16: WARNING: use scnprintf or
> sprintf
> ./drivers/scsi/qla4xxx/ql4_attr.c:173:8-16: WARNING: use scnprintf or
> sprintf
> 
> Signed-off-by: ztt <1549089851@...com>

These should all be converted to sysfs_emit, and not scnprintf.

Thanks,
- Chris Leech