linux-kernel - Re: [PATCH v2] r8152: Suspend USB device before shutdown when WoL is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3c4fd3d8-2b0b-492e-aacc-afafcea98417@rowland.harvard.edu>
Date:   Wed, 19 Jul 2023 14:36:25 -0400
From:   Alan Stern <stern@...land.harvard.edu>
To:     Alexandru Gagniuc <alexandru.gagniuc@...com>
Cc:     linux-usb@...r.kernel.org, netdev@...r.kernel.org,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, hayeswang@...ltek.com, jflf_kernel@....com,
        bjorn@...k.no, svenva@...omium.org, linux-kernel@...r.kernel.org,
        eniac-xw.zhang@...com, stable@...r.kernel.org
Subject: Re: [PATCH v2] r8152: Suspend USB device before shutdown when WoL is
 enabled

On Wed, Jul 19, 2023 at 05:37:56PM +0000, Alexandru Gagniuc wrote:
> For Wake-on-LAN to work from S5 (shutdown), the USB link must be put
> in U3 state. If it is not, and the host "disappears", the chip will
> no longer respond to WoL triggers.
> 
> To resolve this, add a notifier block and register it as a reboot
> notifier. When WoL is enabled, work through the usb_device struct to
> get to the suspend function. Calling this function puts the link in
> the correct state for WoL to function.

How do you know that the link will _remain_ in the correct state?

That is, how do you know that the shutdown processing for the USB host 
controller won't disable the link entirely, thereby preventing WoL from 
working?

Alan Stern