| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAJZ5v0gEhR6q=O-qCyX-H+uMqDUKJ1YeAo6hZcAS4bhZ9StOXA@mail.gmail.com>
Date: Wed, 19 Jul 2023 20:46:20 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Linux ACPI <linux-acpi@...r.kernel.org>
Cc: LKML <linux-kernel@...r.kernel.org>,
Linux PM <linux-pm@...r.kernel.org>,
Michal Wilczynski <michal.wilczynski@...el.com>,
Zhang Rui <rui.zhang@...el.com>,
Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
Daniel Lezcano <daniel.lezcano@...aro.org>
Subject: Re: [PATCH v1 5/7] ACPI: thermal: Use trip point table to register
thermal zones
On Tue, Jul 18, 2023 at 8:21 PM Rafael J. Wysocki <rjw@...ysocki.net> wrote:
>
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
>
> Make the ACPI thermal driver use thermal_zone_device_register_with_trips()
> to register its thermal zones.
>
> For this purpose, make it create a trip point table and pass it to
> thermal_zone_device_register_with_trips() as an argument and use the
> struct thermal_trip_ref introduced previously to connect the generic
> thermal trip structures to the internal data structures representing
> trip points in the driver.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> ---
> drivers/acpi/thermal.c | 100 +++++++++++++++++++++++++++++++++++++++++++++++--
> 1 file changed, 96 insertions(+), 4 deletions(-)
>
> Index: linux-pm/drivers/acpi/thermal.c
> ===================================================================
> --- linux-pm.orig/drivers/acpi/thermal.c
> +++ linux-pm/drivers/acpi/thermal.c
> @@ -93,16 +93,19 @@ MODULE_PARM_DESC(psv, "Disable or overri
> static struct workqueue_struct *acpi_thermal_pm_queue;
>
> struct acpi_thermal_critical {
> + struct thermal_trip_ref trip_ref;
> unsigned long temperature;
> bool valid;
> };
>
> struct acpi_thermal_hot {
> + struct thermal_trip_ref trip_ref;
> unsigned long temperature;
> bool valid;
> };
>
> struct acpi_thermal_passive {
> + struct thermal_trip_ref trip_ref;
> struct acpi_handle_list devices;
> unsigned long temperature;
> unsigned long tc1;
> @@ -112,6 +115,7 @@ struct acpi_thermal_passive {
> };
>
> struct acpi_thermal_active {
> + struct thermal_trip_ref trip_ref;
> struct acpi_handle_list devices;
> unsigned long temperature;
> bool valid;
> @@ -133,6 +137,7 @@ struct acpi_thermal {
> unsigned long polling_frequency;
> volatile u8 zombie;
> struct acpi_thermal_trips trips;
> + struct thermal_trip *trip_table;
> struct acpi_handle_list devices;
> struct thermal_zone_device *thermal_zone;
> int kelvin_offset; /* in millidegrees */
> @@ -186,6 +191,18 @@ static int acpi_thermal_get_polling_freq
> return 0;
> }
>
> +static void acpi_thermal_trip_set_temp(struct acpi_thermal *tz,
> + struct thermal_trip *trip,
> + long temperature)
> +{
> + /* Ignore unititialized trips */
> + if (!trip)
> + return;
This check is actually redundant, because the function never receives
a NULL trip argument.
I'll drop it.
> +
> + trip->temperature = deci_kelvin_to_millicelsius_with_offset(temperature,
> + tz->kelvin_offset);
> +}
> +
> static int acpi_thermal_trips_update(struct acpi_thermal *tz, int flag)
> {
> acpi_status status;
> @@ -745,6 +762,7 @@ static void acpi_thermal_zone_sysfs_remo
>
> static int acpi_thermal_register_thermal_zone(struct acpi_thermal *tz)
> {
> + struct thermal_trip *trip;
> int passive_delay = 0;
> int trip_count = 0;
> int result;
> @@ -765,10 +783,52 @@ static int acpi_thermal_register_thermal
> for (i = 0; i < ACPI_THERMAL_MAX_ACTIVE && tz->trips.active[i].valid; i++)
> trip_count++;
>
> - tz->thermal_zone = thermal_zone_device_register("acpitz", trip_count, 0,
> - tz, &acpi_thermal_zone_ops,
> - NULL, passive_delay,
> - tz->polling_frequency * 100);
> + tz->trip_table = kcalloc(trip_count, sizeof(*tz->trip_table), GFP_KERNEL);
> + if (!tz->trip_table)
> + return -ENOMEM;
> +
> + trip = tz->trip_table;
> +
> + if (tz->trips.critical.valid) {
> + trip->type = THERMAL_TRIP_CRITICAL;
> + acpi_thermal_trip_set_temp(tz, trip,
> + tz->trips.critical.temperature);
> + trip->driver_ref = &tz->trips.critical.trip_ref;
> + trip++;
> + }
> +
> + if (tz->trips.hot.valid) {
> + trip->type = THERMAL_TRIP_HOT;
> + acpi_thermal_trip_set_temp(tz, trip,
> + tz->trips.hot.temperature);
> + trip->driver_ref = &tz->trips.hot.trip_ref;
> + trip++;
> + }
> +
> + if (tz->trips.passive.valid) {
> + trip->type = THERMAL_TRIP_PASSIVE;
> + acpi_thermal_trip_set_temp(tz, trip,
> + tz->trips.passive.temperature);
> + trip->driver_ref = &tz->trips.passive.trip_ref;
> + trip++;
> + }
> +
> + for (i = 0; i < ACPI_THERMAL_MAX_ACTIVE && tz->trips.active[i].valid; i++) {
> + trip->type = THERMAL_TRIP_ACTIVE;
> + acpi_thermal_trip_set_temp(tz, trip,
> + tz->trips.active[i].temperature);
> + trip->driver_ref = &tz->trips.active[i].trip_ref;
> + trip++;
> + }
> +
> + tz->thermal_zone = thermal_zone_device_register_with_trips("acpitz",
> + tz->trip_table,
> + trip_count,
> + 0, tz,
> + &acpi_thermal_zone_ops,
> + NULL,
> + passive_delay,
> + tz->polling_frequency * 100);
> if (IS_ERR(tz->thermal_zone))
> return -ENODEV;
>
> @@ -806,6 +866,7 @@ static void acpi_thermal_unregister_ther
> {
> acpi_thermal_zone_sysfs_remove(tz);
> thermal_zone_device_unregister(tz->thermal_zone);
> + kfree(tz->trip_table);
> tz->thermal_zone = NULL;
> acpi_bus_detach_private_data(tz->device->handle);
> }
> @@ -939,6 +1000,9 @@ static void acpi_thermal_check_fn(struct
> {
> struct acpi_thermal *tz = container_of(work, struct acpi_thermal,
> thermal_check_work);
> + struct thermal_trip *trip;
> + long temperature;
> + int i;
>
> /*
> * In general, it is not sufficient to check the pending bit, because
> @@ -953,6 +1017,34 @@ static void acpi_thermal_check_fn(struct
>
> mutex_lock(&tz->thermal_check_lock);
>
> + trip = tz->trips.passive.trip_ref.trip;
> + if (trip) {
> + /*
> + * This means that the passive trip was valid initially, so
> + * update its temperature in case it has changed or the trip
> + * has become invalid.
> + */
> + temperature = tz->trips.passive.valid ?
> + tz->trips.passive.temperature :
> + THERMAL_TEMP_INVALID;
> + acpi_thermal_trip_set_temp(tz, trip, temperature);
> + }
> +
> + for (i = 0; i < ACPI_THERMAL_MAX_ACTIVE; i++) {
> + trip = tz->trips.active[i].trip_ref.trip;
> + if (trip) {
> + /*
> + * This means that the active trip #i was valid
> + * initially, so update its temperature in case it has
> + * changed or the trip has become invalid.
> + */
> + temperature = tz->trips.active[i].valid ?
> + tz->trips.active[i].temperature :
> + THERMAL_TEMP_INVALID;
> + acpi_thermal_trip_set_temp(tz, trip, temperature);
> + }
> + }
> +
> thermal_zone_device_update(tz->thermal_zone, THERMAL_EVENT_UNSPECIFIED);
>
> refcount_inc(&tz->thermal_check_count);
>
>
>
Powered by blists - more mailing lists